[turbofan] Introduce new JSConstructWithArrayLike operator.

[turbofan] Introduce new JSConstructWithArrayLike operator.

Add a new JSConstructWithArrayLike operator that is backed by the
ConstructWithArrayLike builtin (similar to what was done before
for the JSCallWithArrayLike operator), and use that operator to
optimize Reflect.construct inlining in TurboFan. This is handled
uniformly with JSConstructWithSpread in the JSCallReducer.

Also add missing test coverage for Reflect.construct in optimized
code, especially for some interesting corner cases.

R=petermarshall@chromium.org
BUG=v8:4587, v8:5269
Review-Url: https://codereview.chromium.org/2949813002
Cr-Commit-Position: refs/heads/master@{#46087}
Committed: https://chromium.googlesource.com/v8/v8/+/217012973c2ee5c666260ffd9aa3a6ab475f1aa2

[Benedikt Meurer, 2017-06-20 15:05:58]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 15:06:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 15:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 15:35:36]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-06-21 06:55:11]

Hey Peter,

Here's the next part of the puzzle. Mostly mechanical.
Please take a look.

Thanks,
Benedikt

[petermarshall, 2017-06-21 08:46:19]

LGTM with comments re. CodeFactory and CallableFor

https://codereview.chromium.org/2949813002/diff/1/src/builtins/x64/builtins-x...
File src/builtins/x64/builtins-x64.cc (right):

https://codereview.chromium.org/2949813002/diff/1/src/builtins/x64/builtins-x...
src/builtins/x64/builtins-x64.cc:1851: __
Jump(masm->isolate()->builtins()->ConstructWithArrayLike(),
You can use Builtins::CallableFor(masm->isolate(),
Builtins::kConstructWithArrayLike) here and in the other builtins-arch files
too.

https://codereview.chromium.org/2949813002/diff/1/src/code-factory.cc
File src/code-factory.cc (right):

https://codereview.chromium.org/2949813002/diff/1/src/code-factory.cc#newcode333
src/code-factory.cc:333: Callable CodeFactory::ConstructWithArrayLike(Isolate*
isolate) {
You should be able to use Builtins::CallableFor(masm->isolate(),
Builtins::kConstructWithArrayLike), meaning you don't need to add this
boilerplate in CodeFactory.

[Benedikt Meurer, 2017-06-21 12:05:06]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 12:05:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-06-21 12:05:25]

https://codereview.chromium.org/2949813002/diff/1/src/builtins/x64/builtins-x...
File src/builtins/x64/builtins-x64.cc (right):

https://codereview.chromium.org/2949813002/diff/1/src/builtins/x64/builtins-x...
src/builtins/x64/builtins-x64.cc:1851: __
Jump(masm->isolate()->builtins()->ConstructWithArrayLike(),
This should be done separately (throughout this whole file I'd say).

https://codereview.chromium.org/2949813002/diff/1/src/code-factory.cc
File src/code-factory.cc (right):

https://codereview.chromium.org/2949813002/diff/1/src/code-factory.cc#newcode333
src/code-factory.cc:333: Callable CodeFactory::ConstructWithArrayLike(Isolate*
isolate) {
On 2017/06/21 08:46:19, petermarshall wrote:
> You should be able to use Builtins::CallableFor(masm->isolate(),
> Builtins::kConstructWithArrayLike), meaning you don't need to add this
> boilerplate in CodeFactory.

Done.

[Benedikt Meurer, 2017-06-21 12:05:31]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-06-21 12:05:36]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-06-21 12:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
petermarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2949813002/#ps20001
(title: "Address feedback.")

[commit-bot: I haz the power, 2017-06-21 12:05:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 12:32:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498046736515600,
"parent_rev": "72a597fa215a99842c7a4e5fd72552d40c641fe4", "commit_rev":
"217012973c2ee5c666260ffd9aa3a6ab475f1aa2"}

[commit-bot: I haz the power, 2017-06-21 12:32:06]

Description was changed from

==========
[turbofan] Introduce new JSConstructWithArrayLike operator.

Add a new JSConstructWithArrayLike operator that is backed by the
ConstructWithArrayLike builtin (similar to what was done before
for the JSCallWithArrayLike operator), and use that operator to
optimize Reflect.construct inlining in TurboFan. This is handled
uniformly with JSConstructWithSpread in the JSCallReducer.

Also add missing test coverage for Reflect.construct in optimized
code, especially for some interesting corner cases.

R=petermarshall@chromium.org
BUG=v8:4587,v8:5269
==========

to

==========
[turbofan] Introduce new JSConstructWithArrayLike operator.

Add a new JSConstructWithArrayLike operator that is backed by the
ConstructWithArrayLike builtin (similar to what was done before
for the JSCallWithArrayLike operator), and use that operator to
optimize Reflect.construct inlining in TurboFan. This is handled
uniformly with JSConstructWithSpread in the JSCallReducer.

Also add missing test coverage for Reflect.construct in optimized
code, especially for some interesting corner cases.

R=petermarshall@chromium.org
BUG=v8:4587,v8:5269

Review-Url: https://codereview.chromium.org/2949813002
Cr-Commit-Position: refs/heads/master@{#46087}
Committed:
https://chromium.googlesource.com/v8/v8/+/217012973c2ee5c666260ffd9aa3a6ab475...
==========

[commit-bot: I haz the power, 2017-06-21 12:32:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/217012973c2ee5c666260ffd9aa3a6ab475...