Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: src/builtins/mips/builtins-mips.cc

Issue 2949813002: [turbofan] Introduce new JSConstructWithArrayLike operator. (Closed)
Patch Set: Address feedback. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/ia32/builtins-ia32.cc ('k') | src/builtins/mips64/builtins-mips64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/mips/builtins-mips.cc
diff --git a/src/builtins/mips/builtins-mips.cc b/src/builtins/mips/builtins-mips.cc
index 2b0553a6d15371e4844d27a649b257ac47feb0e8..76a5839f20c8220933a27baa21d1cdf529db81e1 100644
--- a/src/builtins/mips/builtins-mips.cc
+++ b/src/builtins/mips/builtins-mips.cc
@@ -2085,39 +2085,17 @@ void Builtins::Generate_ReflectConstruct(MacroAssembler* masm) {
// -- sp[0] : receiver (undefined)
// -----------------------------------
- // 2. Make sure the target is actually a constructor.
- Label target_not_constructor;
- __ JumpIfSmi(a1, &target_not_constructor);
- __ lw(t0, FieldMemOperand(a1, HeapObject::kMapOffset));
- __ lbu(t0, FieldMemOperand(t0, Map::kBitFieldOffset));
- __ And(t0, t0, Operand(1 << Map::kIsConstructor));
- __ Branch(&target_not_constructor, eq, t0, Operand(zero_reg));
-
- // 3. Make sure the target is actually a constructor.
- Label new_target_not_constructor;
- __ JumpIfSmi(a3, &new_target_not_constructor);
- __ lw(t0, FieldMemOperand(a3, HeapObject::kMapOffset));
- __ lbu(t0, FieldMemOperand(t0, Map::kBitFieldOffset));
- __ And(t0, t0, Operand(1 << Map::kIsConstructor));
- __ Branch(&new_target_not_constructor, eq, t0, Operand(zero_reg));
-
- // 4a. Construct the target with the given new.target and argumentsList.
- __ Jump(masm->isolate()->builtins()->ConstructWithArrayLike(),
- RelocInfo::CODE_TARGET);
+ // 2. We don't need to check explicitly for constructor target here,
+ // since that's the first thing the Construct/ConstructWithArrayLike
+ // builtins will do.
- // 4b. The target is not a constructor, throw an appropriate TypeError.
- __ bind(&target_not_constructor);
- {
- __ sw(a1, MemOperand(sp));
- __ TailCallRuntime(Runtime::kThrowNotConstructor);
- }
+ // 3. We don't need to check explicitly for constructor new.target here,
+ // since that's the second thing the Construct/ConstructWithArrayLike
+ // builtins will do.
- // 4c. The new.target is not a constructor, throw an appropriate TypeError.
- __ bind(&new_target_not_constructor);
- {
- __ sw(a3, MemOperand(sp));
- __ TailCallRuntime(Runtime::kThrowNotConstructor);
- }
+ // 4. Construct the target with the given new.target and argumentsList.
+ __ Jump(masm->isolate()->builtins()->ConstructWithArrayLike(),
+ RelocInfo::CODE_TARGET);
}
static void EnterArgumentsAdaptorFrame(MacroAssembler* masm) {
« no previous file with comments | « src/builtins/ia32/builtins-ia32.cc ('k') | src/builtins/mips64/builtins-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698