Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1996)

Unified Diff: src/builtins/arm64/builtins-arm64.cc

Issue 2949813002: [turbofan] Introduce new JSConstructWithArrayLike operator. (Closed)
Patch Set: Address feedback. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/arm/builtins-arm.cc ('k') | src/builtins/builtins-call-gen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/arm64/builtins-arm64.cc
diff --git a/src/builtins/arm64/builtins-arm64.cc b/src/builtins/arm64/builtins-arm64.cc
index f6d639085a9b046535ced49f93132378423a8cfe..ad6eab5ea8e3eb64e672b31844839098fb0c0b3f 100644
--- a/src/builtins/arm64/builtins-arm64.cc
+++ b/src/builtins/arm64/builtins-arm64.cc
@@ -2175,39 +2175,17 @@ void Builtins::Generate_ReflectConstruct(MacroAssembler* masm) {
// -- jssp[0] : receiver (undefined)
// -----------------------------------
- // 2. Make sure the target is actually a constructor.
- Label target_not_constructor;
- __ JumpIfSmi(target, &target_not_constructor);
- __ Ldr(x10, FieldMemOperand(target, HeapObject::kMapOffset));
- __ Ldrb(x10, FieldMemOperand(x10, Map::kBitFieldOffset));
- __ TestAndBranchIfAllClear(x10, 1 << Map::kIsConstructor,
- &target_not_constructor);
-
- // 3. Make sure the new.target is actually a constructor.
- Label new_target_not_constructor;
- __ JumpIfSmi(new_target, &new_target_not_constructor);
- __ Ldr(x10, FieldMemOperand(new_target, HeapObject::kMapOffset));
- __ Ldrb(x10, FieldMemOperand(x10, Map::kBitFieldOffset));
- __ TestAndBranchIfAllClear(x10, 1 << Map::kIsConstructor,
- &new_target_not_constructor);
-
- // 4a. Construct the target with the given new.target and argumentsList.
- __ Jump(masm->isolate()->builtins()->ConstructWithArrayLike(),
- RelocInfo::CODE_TARGET);
+ // 2. We don't need to check explicitly for constructor target here,
+ // since that's the first thing the Construct/ConstructWithArrayLike
+ // builtins will do.
- // 4b. The target is not a constructor, throw an appropriate TypeError.
- __ Bind(&target_not_constructor);
- {
- __ Poke(target, 0);
- __ TailCallRuntime(Runtime::kThrowNotConstructor);
- }
+ // 3. We don't need to check explicitly for constructor new.target here,
+ // since that's the second thing the Construct/ConstructWithArrayLike
+ // builtins will do.
- // 4c. The new.target is not a constructor, throw an appropriate TypeError.
- __ Bind(&new_target_not_constructor);
- {
- __ Poke(new_target, 0);
- __ TailCallRuntime(Runtime::kThrowNotConstructor);
- }
+ // 4. Construct the target with the given new.target and argumentsList.
+ __ Jump(masm->isolate()->builtins()->ConstructWithArrayLike(),
+ RelocInfo::CODE_TARGET);
}
static void EnterArgumentsAdaptorFrame(MacroAssembler* masm) {
« no previous file with comments | « src/builtins/arm/builtins-arm.cc ('k') | src/builtins/builtins-call-gen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698