Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: src/compiler/verifier.cc

Issue 2949813002: [turbofan] Introduce new JSConstructWithArrayLike operator. (Closed)
Patch Set: Address feedback. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/compiler/reflect-construct.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 696 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 Node* context = NodeProperties::GetContextInput(node); 707 Node* context = NodeProperties::GetContextInput(node);
708 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type 708 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type
709 // OtherInternal on certain contexts, i.e. those from OsrValue inputs. 709 // OtherInternal on certain contexts, i.e. those from OsrValue inputs.
710 CheckTypeMaybe(context, Type::OtherInternal()); 710 CheckTypeMaybe(context, Type::OtherInternal());
711 CheckTypeIs(node, Type::OtherInternal()); 711 CheckTypeIs(node, Type::OtherInternal());
712 break; 712 break;
713 } 713 }
714 714
715 case IrOpcode::kJSConstructForwardVarargs: 715 case IrOpcode::kJSConstructForwardVarargs:
716 case IrOpcode::kJSConstruct: 716 case IrOpcode::kJSConstruct:
717 case IrOpcode::kJSConstructWithArrayLike:
717 case IrOpcode::kJSConstructWithSpread: 718 case IrOpcode::kJSConstructWithSpread:
718 case IrOpcode::kJSConvertReceiver: 719 case IrOpcode::kJSConvertReceiver:
719 // Type is Receiver. 720 // Type is Receiver.
720 CheckTypeIs(node, Type::Receiver()); 721 CheckTypeIs(node, Type::Receiver());
721 break; 722 break;
722 case IrOpcode::kJSCallForwardVarargs: 723 case IrOpcode::kJSCallForwardVarargs:
723 case IrOpcode::kJSCall: 724 case IrOpcode::kJSCall:
724 case IrOpcode::kJSCallWithArrayLike: 725 case IrOpcode::kJSCallWithArrayLike:
725 case IrOpcode::kJSCallWithSpread: 726 case IrOpcode::kJSCallWithSpread:
726 case IrOpcode::kJSCallRuntime: 727 case IrOpcode::kJSCallRuntime:
(...skipping 1064 matching lines...) Expand 10 before | Expand all | Expand 10 after
1791 replacement->op()->EffectOutputCount() > 0); 1792 replacement->op()->EffectOutputCount() > 0);
1792 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1793 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1793 replacement->opcode() == IrOpcode::kFrameState); 1794 replacement->opcode() == IrOpcode::kFrameState);
1794 } 1795 }
1795 1796
1796 #endif // DEBUG 1797 #endif // DEBUG
1797 1798
1798 } // namespace compiler 1799 } // namespace compiler
1799 } // namespace internal 1800 } // namespace internal
1800 } // namespace v8 1801 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/compiler/reflect-construct.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698