Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2949453002: Make EFlexDirection an enum class. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EFlexDirection an enum class. This patch makes EFlexDirection an enum class for type safety. Bug: 684966 Review-Url: https://codereview.chromium.org/2949453002 Cr-Commit-Position: refs/heads/master@{#480348} Committed: https://chromium.googlesource.com/chromium/src/+/10daf3e2c179c924705b3b4a1e2036562bcdc7ef

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -39 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 8 chunks +18 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
shend
Hi Alan, PTAL
3 years, 6 months ago (2017-06-19 00:29:11 UTC) #8
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-19 04:24:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949453002/20001
3 years, 6 months ago (2017-06-19 04:28:58 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 04:33:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/10daf3e2c179c924705b3b4a1e20...

Powered by Google App Engine
This is Rietveld 408576698