Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2949453002: Make EFlexDirection an enum class. (Closed)
Patch Set: Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 755 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 } 766 }
767 767
768 NOTREACHED(); 768 NOTREACHED();
769 return HORIZONTAL; 769 return HORIZONTAL;
770 } 770 }
771 771
772 template <> 772 template <>
773 inline CSSIdentifierValue::CSSIdentifierValue(EFlexDirection e) 773 inline CSSIdentifierValue::CSSIdentifierValue(EFlexDirection e)
774 : CSSValue(kIdentifierClass) { 774 : CSSValue(kIdentifierClass) {
775 switch (e) { 775 switch (e) {
776 case kFlowRow: 776 case EFlexDirection::kRow:
777 value_id_ = CSSValueRow; 777 value_id_ = CSSValueRow;
778 break; 778 break;
779 case kFlowRowReverse: 779 case EFlexDirection::kRowReverse:
780 value_id_ = CSSValueRowReverse; 780 value_id_ = CSSValueRowReverse;
781 break; 781 break;
782 case kFlowColumn: 782 case EFlexDirection::kColumn:
783 value_id_ = CSSValueColumn; 783 value_id_ = CSSValueColumn;
784 break; 784 break;
785 case kFlowColumnReverse: 785 case EFlexDirection::kColumnReverse:
786 value_id_ = CSSValueColumnReverse; 786 value_id_ = CSSValueColumnReverse;
787 break; 787 break;
788 } 788 }
789 } 789 }
790 790
791 template <> 791 template <>
792 inline EFlexDirection CSSIdentifierValue::ConvertTo() const { 792 inline EFlexDirection CSSIdentifierValue::ConvertTo() const {
793 switch (value_id_) { 793 switch (value_id_) {
794 case CSSValueRow: 794 case CSSValueRow:
795 return kFlowRow; 795 return EFlexDirection::kRow;
796 case CSSValueRowReverse: 796 case CSSValueRowReverse:
797 return kFlowRowReverse; 797 return EFlexDirection::kRowReverse;
798 case CSSValueColumn: 798 case CSSValueColumn:
799 return kFlowColumn; 799 return EFlexDirection::kColumn;
800 case CSSValueColumnReverse: 800 case CSSValueColumnReverse:
801 return kFlowColumnReverse; 801 return EFlexDirection::kColumnReverse;
802 default: 802 default:
803 break; 803 break;
804 } 804 }
805 805
806 NOTREACHED(); 806 NOTREACHED();
807 return kFlowRow; 807 return EFlexDirection::kRow;
808 } 808 }
809 809
810 template <> 810 template <>
811 inline CSSIdentifierValue::CSSIdentifierValue(EFlexWrap e) 811 inline CSSIdentifierValue::CSSIdentifierValue(EFlexWrap e)
812 : CSSValue(kIdentifierClass) { 812 : CSSValue(kIdentifierClass) {
813 switch (e) { 813 switch (e) {
814 case kFlexNoWrap: 814 case kFlexNoWrap:
815 value_id_ = CSSValueNowrap; 815 value_id_ = CSSValueNowrap;
816 break; 816 break;
817 case kFlexWrap: 817 case kFlexWrap:
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
2624 default: 2624 default:
2625 break; 2625 break;
2626 } 2626 }
2627 NOTREACHED(); 2627 NOTREACHED();
2628 return kContainsNone; 2628 return kContainsNone;
2629 } 2629 }
2630 2630
2631 } // namespace blink 2631 } // namespace blink
2632 2632
2633 #endif 2633 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698