Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2944793002: Make EFlexWrap an enum class. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EFlexWrap an enum class. This patch makes EFlexWrap an enum class for type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2944793002 Cr-Commit-Position: refs/heads/master@{#480391} Committed: https://chromium.googlesource.com/chromium/src/+/2ad506ac98a4b768f90187af5e35cf51815be6a8

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
shend
Hi Alan, PTAL
3 years, 6 months ago (2017-06-19 00:29:34 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-19 04:23:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944793002/1
3 years, 6 months ago (2017-06-19 04:36:25 UTC) #9
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/style/ComputedStyleConstants.h: While running git apply --index -3 -p1; error: patch ...
3 years, 6 months ago (2017-06-19 04:43:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944793002/20001
3 years, 6 months ago (2017-06-19 10:34:23 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 10:38:48 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2ad506ac98a4b768f90187af5e35...

Powered by Google App Engine
This is Rietveld 408576698