third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp - Issue 2949453002: Make EFlexDirection an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

Issue 2949453002: Make EFlexDirection an enum class. (Closed)

Patch Set: Fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp b/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

index fc4b6f2d5fa439221f3932b9ebf90741fd4b8250..8bda11e5a97b1e6f6d1226ae754563032de9a218 100644

--- a/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp

@@ -99,7 +99,8 @@ void LayoutSliderContainer::ComputeLogicalHeight(

void LayoutSliderContainer::UpdateLayout() {

HTMLInputElement* input = toHTMLInputElement(GetNode()->OwnerShadowHost());

bool is_vertical = HasVerticalAppearance(input);

- MutableStyleRef().SetFlexDirection(is_vertical ? kFlowColumn : kFlowRow);

+ MutableStyleRef().SetFlexDirection(is_vertical ? EFlexDirection::kColumn

+ : EFlexDirection::kRow);

TextDirection old_text_direction = Style()->Direction();

if (is_vertical) {

// FIXME: Work around rounding issues in RTL vertical sliders. We want them