Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed)

Created:
6 years, 7 months ago by darin (slow to review)
Modified:
6 years, 6 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: more idiomatic C++ bindings This change eliminates AllocationScope in favor of heap allocating the "wrapper" classes, which are now no longer wrappers in the true sense but rather deep copies of the archived structs. We still use the term "wrapper" in the code generator. With this design, the fact that structs are encoded as pointers (that may be null) is more apparent. For example, a Foo struct may be allocated and stored in a FooPtr. The FooPtr implements move-only semantics. This is because some of the members of Foo may be move-only (e.g., handles). Strings are now just thin wrappers around std::string that impose nullability and a more restrictive API. It is not possible to mutate the elements of a string after it has been created. String acts like a pointer to a possibly null array of characters, which is very similar to a char*. Arrays are now just thin wrappers around std::vector that impose nullability and a more restrictive API. Unlike String, Array does support mutation of its elements after creation, but there is no support for resizing an array. (We can add support for push_back and resize if needed.) BUG=365922 R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273527

Patch Set 1 #

Patch Set 2 : snapshot #

Patch Set 3 : WIP #

Patch Set 4 : snapshot #

Patch Set 5 : more #

Total comments: 6

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : string serialization #

Patch Set 9 : serialization #

Total comments: 1

Patch Set 10 : array serialization #

Patch Set 11 : snapshot #

Patch Set 12 : snapshot #

Patch Set 13 : snapshot #

Patch Set 14 : cleanup #

Patch Set 15 : #

Patch Set 16 : cleanup #

Patch Set 17 : rebase #

Patch Set 18 : GN updates #

Patch Set 19 : fix windows bustage #

Total comments: 16

Patch Set 20 : improvements per review feedback #

Total comments: 4

Patch Set 21 : rebase #

Patch Set 22 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2098 lines, -2462 lines) Patch
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 1 2 3 4 5 6 3 chunks +62 lines, -68 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -1 line 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +68 lines, -74 lines 0 comments Download
M mojo/aura/window_tree_host_mojo.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/aura/window_tree_host_mojo.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 5 chunks +12 lines, -16 lines 0 comments Download
M mojo/common/common_type_converters.h View 1 2 3 2 chunks +3 lines, -7 lines 0 comments Download
M mojo/common/common_type_converters.cc View 1 2 3 4 5 6 1 chunk +11 lines, -14 lines 0 comments Download
M mojo/common/common_type_converters_unittest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +9 lines, -14 lines 0 comments Download
D mojo/environment/buffer_tls.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/environment/buffer_tls_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/environment/buffer_tls_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +4 lines, -11 lines 0 comments Download
M mojo/examples/compositor_app/compositor_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/compositor_app/compositor_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/dbus_echo/dbus_echo_app.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +1 line, -3 lines 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +11 lines, -14 lines 0 comments Download
M mojo/examples/pepper_container_app/type_converters.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +35 lines, -35 lines 0 comments Download
M mojo/examples/sample_app/gles2_client_impl.cc View 1 2 3 4 5 6 7 8 9 4 chunks +9 lines, -9 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +16 lines, -17 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 2 3 4 5 6 7 8 9 4 chunks +3 lines, -6 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/mojo_public.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +6 lines, -8 lines 0 comments Download
M mojo/public/cpp/application/connect.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/application.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/service_connector.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +7 lines, -7 lines 0 comments Download
D mojo/public/cpp/bindings/allocation_scope.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
M mojo/public/cpp/bindings/array.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +63 lines, -108 lines 0 comments Download
D mojo/public/cpp/bindings/buffer.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -34 lines 0 comments Download
M mojo/public/cpp/bindings/callback.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 15 chunks +57 lines, -56 lines 0 comments Download
M mojo/public/cpp/bindings/callback.h.pump View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/TODO View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/array.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -38 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.h View 1 2 3 4 5 6 7 8 9 10 11 12 10 chunks +37 lines, -170 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -18 lines 0 comments Download
A mojo/public/cpp/bindings/lib/array_serialization.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +179 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_internal.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +12 lines, -90 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_serialization.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
A mojo/public/cpp/bindings/lib/buffer.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +24 lines, -0 lines 0 comments Download
D mojo/public/cpp/bindings/lib/buffer.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -27 lines 0 comments Download
M mojo/public/cpp/bindings/lib/callback_internal.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +6 lines, -35 lines 0 comments Download
M mojo/public/cpp/bindings/lib/fixed_buffer.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/fixed_buffer.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -3 lines 0 comments Download
D mojo/public/cpp/bindings/lib/scratch_buffer.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/public/cpp/bindings/lib/scratch_buffer.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -98 lines 0 comments Download
A mojo/public/cpp/bindings/lib/string_serialization.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +20 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/lib/string_serialization.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +38 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/lib/template_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +89 lines, -0 lines 0 comments Download
D mojo/public/cpp/bindings/passable.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -73 lines 0 comments Download
A mojo/public/cpp/bindings/string.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +151 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/struct_ptr.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +154 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/array_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +111 lines, -82 lines 0 comments Download
M mojo/public/cpp/bindings/tests/buffer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +0 lines, -74 lines 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 11 chunks +46 lines, -51 lines 0 comments Download
M mojo/public/cpp/bindings/tests/request_response_unittest.cc View 1 2 3 4 5 6 8 chunks +8 lines, -23 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 8 chunks +126 lines, -141 lines 0 comments Download
A mojo/public/cpp/bindings/tests/string_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +65 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/tests/struct_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +140 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/type_conversion_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 9 chunks +54 lines, -100 lines 0 comments Download
M mojo/public/cpp/bindings/type_converter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +23 lines, -66 lines 0 comments Download
D mojo/public/cpp/environment/buffer_tls.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/public/cpp/environment/lib/buffer_tls.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/public/cpp/environment/lib/buffer_tls_setup.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/public/cpp/environment/lib/environment.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
D mojo/public/tools/bindings/generators/cpp_templates/enum_traits.tmpl View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 6 chunks +27 lines, -19 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +33 lines, -13 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/params_definition.tmpl View 1 2 3 4 5 6 7 8 9 10 2 chunks +5 lines, -18 lines 0 comments Download
D mojo/public/tools/bindings/generators/cpp_templates/struct_builder_definition.tmpl View 1 chunk +0 lines, -65 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -14 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -36 lines 0 comments Download
D mojo/public/tools/bindings/generators/cpp_templates/struct_destructor.tmpl View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -11 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -37 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +51 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -81 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +21 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +48 lines, -13 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/service_manager/service_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/service_manager/service_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +2 lines, -5 lines 0 comments Download
M mojo/services/dbus_echo/dbus_echo_service.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/gles2/command_buffer_type_conversions.h View 1 2 3 4 1 chunk +6 lines, -7 lines 0 comments Download
M mojo/services/gles2/command_buffer_type_conversions.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +21 lines, -22 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 5 chunks +21 lines, -29 lines 0 comments Download
M mojo/services/public/cpp/geometry/geometry_type_converters.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +9 lines, -15 lines 0 comments Download
M mojo/services/public/cpp/geometry/lib/geometry_type_converters.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +31 lines, -26 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 6 chunks +14 lines, -14 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 5 chunks +10 lines, -25 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 10 chunks +19 lines, -23 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 38 chunks +22 lines, -68 lines 0 comments Download
M mojo/shell/app_child_process.cc View 1 2 3 4 5 6 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/shell/dbus_service_loader_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/shell/out_of_process_dynamic_service_runner.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
sky
https://codereview.chromium.org/294833002/diff/60001/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc File chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc (right): https://codereview.chromium.org/294833002/diff/60001/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc#newcode40 chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc:40: AutocompleteAdditionalInfoPtr item(AutocompleteAdditionalInfo::New()); It's too bad the empty constructor can't ...
6 years, 7 months ago (2014-05-22 14:12:04 UTC) #1
darin (slow to review)
Yeah, I went with FooPtr() being null since it represents a pointer variable. I went ...
6 years, 7 months ago (2014-05-22 14:26:38 UTC) #2
yzshen1
Here are a few comments. I will need to read and think in more details... ...
6 years, 7 months ago (2014-05-22 17:13:52 UTC) #3
darin (slow to review)
On Thu, May 22, 2014 at 10:13 AM, <yzshen@chromium.org> wrote: > Here are a few ...
6 years, 7 months ago (2014-05-22 19:49:24 UTC) #4
darin (slow to review)
On Thu, May 22, 2014 at 12:49 PM, Darin Fisher <darin@chromium.org> wrote: > > > ...
6 years, 7 months ago (2014-05-22 19:49:59 UTC) #5
darin (slow to review)
Latest WIP patch makes mojo::String no longer have move semantics. This allows for implicit assignment ...
6 years, 7 months ago (2014-05-23 06:08:32 UTC) #6
yzshen1
I like the new String! https://codereview.chromium.org/294833002/diff/140001/mojo/public/cpp/bindings/lib/array_internal.h File mojo/public/cpp/bindings/lib/array_internal.h (right): https://codereview.chromium.org/294833002/diff/140001/mojo/public/cpp/bindings/lib/array_internal.h#newcode363 mojo/public/cpp/bindings/lib/array_internal.h:363: char buf[sizeof(T) + (8 ...
6 years, 7 months ago (2014-05-23 17:45:04 UTC) #7
darin (slow to review)
But sizeof(T) might not be a multiple of 8. This change tries to ensure that ...
6 years, 7 months ago (2014-05-23 17:50:02 UTC) #8
chromium-reviews
On Fri, May 23, 2014 at 10:50 AM, Darin Fisher <darin@chromium.org> wrote: > But sizeof(T) ...
6 years, 7 months ago (2014-05-23 17:56:54 UTC) #9
darin (slow to review)
The wrapper classes (i.e the "structs" held in this array are not padded out). On ...
6 years, 7 months ago (2014-05-23 18:56:05 UTC) #10
darin (slow to review)
OK, I think this is ready for review. PTAL, thanks! (Sorry for the big CL.) ...
6 years, 7 months ago (2014-05-27 05:15:43 UTC) #11
yzshen1
(Sorry if any of the comments doesn't make sense. Pretty difficult to read through the ...
6 years, 7 months ago (2014-05-27 22:16:58 UTC) #12
darin (slow to review)
On Tue, May 27, 2014 at 3:16 PM, <yzshen@chromium.org> wrote: > (Sorry if any of ...
6 years, 6 months ago (2014-05-28 03:48:46 UTC) #13
darin (slow to review)
On 2014/05/27 22:16:58, yzshen1 wrote: ... > https://codereview.chromium.org/294833002/diff/340001/mojo/public/cpp/bindings/lib/array_serialization.h > File mojo/public/cpp/bindings/lib/array_serialization.h (right): > > https://codereview.chromium.org/294833002/diff/340001/mojo/public/cpp/bindings/lib/array_serialization.h#newcode139 ...
6 years, 6 months ago (2014-05-28 19:04:05 UTC) #14
yzshen1
LGTM with a few nits. Thanks! https://codereview.chromium.org/294833002/diff/360001/mojo/public/cpp/bindings/lib/array_serialization.h File mojo/public/cpp/bindings/lib/array_serialization.h (right): https://codereview.chromium.org/294833002/diff/360001/mojo/public/cpp/bindings/lib/array_serialization.h#newcode88 mojo/public/cpp/bindings/lib/array_serialization.h:88: if (!input) It ...
6 years, 6 months ago (2014-05-28 19:45:49 UTC) #15
yzshen1
LGTM with a few nits. Thanks! https://codereview.chromium.org/294833002/diff/360001/mojo/public/cpp/bindings/lib/array_serialization.h File mojo/public/cpp/bindings/lib/array_serialization.h (right): https://codereview.chromium.org/294833002/diff/360001/mojo/public/cpp/bindings/lib/array_serialization.h#newcode88 mojo/public/cpp/bindings/lib/array_serialization.h:88: if (!input) It ...
6 years, 6 months ago (2014-05-28 19:45:50 UTC) #16
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 6 months ago (2014-05-29 00:14:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/294833002/380001
6 years, 6 months ago (2014-05-29 00:15:56 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 05:01:07 UTC) #19
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 6 months ago (2014-05-29 17:59:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/294833002/400001
6 years, 6 months ago (2014-05-29 18:01:06 UTC) #21
darin (slow to review)
6 years, 6 months ago (2014-05-29 19:00:55 UTC) #22
Message was sent while issue was closed.
Committed patchset #22 manually as r273527 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698