Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: mojo/service_manager/service_manager.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/service_manager/service_manager.cc
diff --git a/mojo/service_manager/service_manager.cc b/mojo/service_manager/service_manager.cc
index 3aa955e39383f28246c78fdaa8db849fff064f47..01a87f0980d369fe995484656f3dc31ee2a62e04 100644
--- a/mojo/service_manager/service_manager.cc
+++ b/mojo/service_manager/service_manager.cc
@@ -10,7 +10,6 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/stl_util.h"
-#include "mojo/public/cpp/bindings/allocation_scope.h"
#include "mojo/service_manager/service_loader.h"
namespace mojo {
@@ -31,16 +30,14 @@ class ServiceManager::ServiceFactory : public InterfaceImpl<ServiceProvider> {
}
void ConnectToClient(ScopedMessagePipeHandle handle) {
- if (handle.is_valid()) {
- AllocationScope scope;
+ if (handle.is_valid())
client()->ConnectToService(url_.spec(), handle.Pass());
- }
}
// ServiceProvider implementation:
virtual void ConnectToService(const String& url,
ScopedMessagePipeHandle client_pipe) OVERRIDE {
- manager_->ConnectToService(GURL(url.To<std::string>()), client_pipe.Pass());
+ manager_->ConnectToService(GURL(url), client_pipe.Pass());
}
const GURL& url() const { return url_; }
@@ -70,7 +67,7 @@ class ServiceManager::TestAPI::TestServiceProviderConnection
// ServiceProvider:
virtual void ConnectToService(const String& url,
ScopedMessagePipeHandle client_pipe) OVERRIDE {
- manager_->ConnectToService(GURL(url.To<std::string>()), client_pipe.Pass());
+ manager_->ConnectToService(GURL(url), client_pipe.Pass());
}
private:
« no previous file with comments | « mojo/public/tools/bindings/pylib/mojom/generate/generator.py ('k') | mojo/service_manager/service_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698