mojo/examples/launcher/launcher.cc - Issue 294833002: Mojo: more idiomatic C++ bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/examples/launcher/launcher.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/examples/launcher/launcher.cc

diff --git a/mojo/examples/launcher/launcher.cc b/mojo/examples/launcher/launcher.cc

index bc8ccfd73e5987f61bba213e93acf2a0c6055fc2..7734c0e1065025f19b4cfd1a80630aa772d5b84e 100644

--- a/mojo/examples/launcher/launcher.cc

+++ b/mojo/examples/launcher/launcher.cc

@@ -16,7 +16,6 @@

#include "mojo/aura/window_tree_host_mojo.h"

#include "mojo/examples/launcher/launcher.mojom.h"

#include "mojo/public/cpp/application/application.h"

-#include "mojo/public/cpp/bindings/allocation_scope.h"

#include "mojo/public/cpp/gles2/gles2.h"

#include "mojo/public/cpp/system/core.h"

#include "mojo/public/interfaces/service_provider/service_provider.mojom.h"

@@ -221,8 +220,7 @@ class LauncherImpl : public InterfaceImpl<Launcher>,

// Overridden from URLReceiver:

virtual void OnURLEntered(const std::string& url_text) OVERRIDE {

- AllocationScope scope;

- client()->OnURLEntered(url_text);

+ client()->OnURLEntered(String::From(url_text));

}

void HostContextCreated() {