mojo/shell/dbus_service_loader_linux.cc - Issue 294833002: Mojo: more idiomatic C++ bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/dbus_service_loader_linux.cc

Issue 294833002: Mojo: more idiomatic C++ bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/dbus_service_loader_linux.cc

diff --git a/mojo/shell/dbus_service_loader_linux.cc b/mojo/shell/dbus_service_loader_linux.cc

index 99cf1a9d3b10bfb9a7a52e989853dd6673678c6c..d7de3097187bf0b5a6e8480934693b1e31ee88bc 100644

--- a/mojo/shell/dbus_service_loader_linux.cc

+++ b/mojo/shell/dbus_service_loader_linux.cc

@@ -19,7 +19,6 @@

#include "mojo/common/channel_init.h"

#include "mojo/dbus/dbus_external_service.h"

#include "mojo/embedder/platform_channel_pair.h"

-#include "mojo/public/cpp/bindings/allocation_scope.h"

#include "mojo/shell/context.h"

#include "mojo/shell/external_service.mojom.h"

#include "mojo/shell/keep_alive.h"

@@ -105,7 +104,6 @@ class DBusServiceLoader::LoadContext {

// Sends a ShellHandle over to the now-connected externally-running service,

// using the Mojo ExternalService API.

void ActivateService(dbus::Response* response) {

- mojo::AllocationScope scope;

external_service_->Activate(

mojo::ScopedMessagePipeHandle(

mojo::MessagePipeHandle(

« no previous file with comments | « mojo/shell/app_child_process.cc ('k') | mojo/shell/out_of_process_dynamic_service_runner.cc » ('j') | no next file with comments »