Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2948193002: Merge AnimationTimeline and DocumentTimeline (Closed)

Created:
3 years, 6 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, krit, eae+blinkwatch, Eric Willigers, fmalita+watch_chromium.org, fs, gyuyoung2, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pdr+svgwatchlist_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, smcgruer
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge AnimationTimeline and DocumentTimeline Following from https://codereview.chromium.org/2944423003 this patch merges the AnimationTimeline and DocumentTimeline classes and corresponding unit tests. This involves - moving the test from DoumentTimelineTest to AnimationTimelineTest - deleting DocumentTimeline{,Test} - renaming AnimationTimeline{,Test} to DocumentTimeline{,Test} BUG=624639 Review-Url: https://codereview.chromium.org/2948193002 Cr-Commit-Position: refs/heads/master@{#482557} Committed: https://chromium.googlesource.com/chromium/src/+/17bda8398e00987e311824a5662b752e74d0241c

Patch Set 1 #

Patch Set 2 : Rebase / IDL syntax fix #

Patch Set 3 : Fix rebase error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -845 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationTimeline.h View 1 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationTimeline.cpp View 1 1 chunk +0 lines, -305 lines 0 comments Download
D third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 1 1 chunk +0 lines, -296 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorPendingAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentTimeline.h View 1 2 1 chunk +121 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/DocumentTimeline.cpp View 1 13 chunks +36 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentTimeline.idl View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentTimelineTest.cpp View 1 2 1 chunk +238 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SuperAnimationTimeline.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
suzyh_UTC10 (ex-contributor)
Here's patch 2 of 3 for the AnimationTimeline/DocumentTimeline move
3 years, 6 months ago (2017-06-22 00:50:37 UTC) #2
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-22 01:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948193002/20001
3 years, 5 months ago (2017-06-27 03:38:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/104610)
3 years, 5 months ago (2017-06-27 04:01:34 UTC) #9
suzyh_UTC10 (ex-contributor)
On 2017/06/27 at 04:01:34, commit-bot wrote: > Try jobs failed on following builders: > linux_chromium_tsan_rel_ng ...
3 years, 5 months ago (2017-06-27 04:56:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948193002/40001
3 years, 5 months ago (2017-06-27 04:58:37 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 07:04:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/17bda8398e00987e311824a5662b...

Powered by Google App Engine
This is Rietveld 408576698