Make AnimationTimeline.currentTime readonly

Make AnimationTimeline.currentTime readonly

To bring in line with spec
https://w3c.github.io/web-animations/#the-animationtimeline-interface

BUG=624639
Review-Url: https://codereview.chromium.org/2952783002
Cr-Commit-Position: refs/heads/master@{#481800}
Committed: https://chromium.googlesource.com/chromium/src/+/5c438726c3ecb09e690cf079776315f7425cb3a0

[suzyh_UTC10 (ex-contributor), 2017-06-21 04:45:39]

suzyh@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-06-21 04:47:01]

suzyh@chromium.org changed reviewers:
+ foolip@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-06-21 04:50:33]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 04:50:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2017-06-21 05:25:34]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-06-21 05:25:35]

https://codereview.chromium.org/2952783002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html
(right):

https://codereview.chromium.org/2952783002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html:28:
idlArray.add_idls(
I'm not sure why this change is part of this patch.

[commit-bot: I haz the power, 2017-06-21 06:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 06:09:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[suzyh_UTC10 (ex-contributor), 2017-06-21 21:55:26]

https://codereview.chromium.org/2952783002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html
(right):

https://codereview.chromium.org/2952783002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html:28:
idlArray.add_idls(
On 2017/06/21 at 05:25:35, alancutter wrote:
> I'm not sure why this change is part of this patch.

This enables a test that picks up that the currentTime attribute should be
readonly :)

[Eric Willigers, 2017-06-21 22:26:49]

lgtm

[alancutter (OOO until 2018), 2017-06-22 01:31:36]

lgtm

[suzyh_UTC10 (ex-contributor), 2017-06-22 03:12:30]

foolip: please review for */webexposed/ changes

[suzyh_UTC10 (ex-contributor), 2017-06-22 03:12:38]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 03:12:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 05:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 05:05:19]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-06-22 10:12:51]

lgtm

Since setCurrentTime was only called from bindings and tests, it would not be
possible to consolidate it with SetCurrentTimeInternal, if you like.

https://codereview.chromium.org/2952783002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html
(right):

https://codereview.chromium.org/2952783002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html:28:
idlArray.add_idls(
Not for this CL, but separate it would be nice to move the IDL to
https://github.com/w3c/web-platform-tests/tree/master/interfaces. I expect that
eventually we'll be able to keep those in sync more effectively with tooling.

[foolip, 2017-06-22 10:13:08]

On 2017/06/22 10:12:51, foolip wrote:
> Since setCurrentTime was only called from bindings and tests, it would not be
> possible to consolidate it with SetCurrentTimeInternal, if you like.

s/not/now/

[suzyh_UTC10 (ex-contributor), 2017-06-23 00:31:39]

On 2017/06/22 at 10:12:51, foolip wrote:
> lgtm
> 
> Since setCurrentTime was only called from bindings and tests, it would not be
possible to consolidate it with SetCurrentTimeInternal, if you like.

Good catch. Looks like SetCurrentTimeInternal isn't used anywhere but tests
either; deleting them both.


>
https://codereview.chromium.org/2952783002/diff/20001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html
(right):
> 
>
https://codereview.chromium.org/2952783002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html:28:
idlArray.add_idls(
> Not for this CL, but separate it would be nice to move the IDL to
https://github.com/w3c/web-platform-tests/tree/master/interfaces. I expect that
eventually we'll be able to keep those in sync more effectively with tooling.

Filed crbug.com/736154

[alancutter (OOO until 2018), 2017-06-23 00:32:34]

lgtm

[suzyh_UTC10 (ex-contributor), 2017-06-23 00:32:52]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-06-23 00:32:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2952783002/#ps40001
(title: "Delete obsolete setCurrentTime* methods")

[commit-bot: I haz the power, 2017-06-23 00:33:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 03:12:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498177972240030,
"parent_rev": "f7e272242d8becf099d77d7b222afad07286401d", "commit_rev":
"5c438726c3ecb09e690cf079776315f7425cb3a0"}

[commit-bot: I haz the power, 2017-06-23 03:12:44]

Description was changed from

==========
Make AnimationTimeline.currentTime readonly

To bring in line with spec
https://w3c.github.io/web-animations/#the-animationtimeline-interface

BUG=624639
==========

to

==========
Make AnimationTimeline.currentTime readonly

To bring in line with spec
https://w3c.github.io/web-animations/#the-animationtimeline-interface

BUG=624639

Review-Url: https://codereview.chromium.org/2952783002
Cr-Commit-Position: refs/heads/master@{#481800}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c438726c3ecb09e690cf0797763...
==========

[commit-bot: I haz the power, 2017-06-23 03:12:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5c438726c3ecb09e690cf0797763...