Use tighter typing in table rendering code

Use tighter typing in table rendering code

Use tighter typing in table rendering code:
- Rename RenderTableSection's firstChild() / lastChild() to firstRow() / lastRow()
  and have them return a RenderTableRow* instead of a RenderObject*.
- Rename RenderTableRow's firstChild() / lastChild() to firstCell() / lastCell()
  and have them return a RenderTableCell* instead of a RenderObject*.

Add previousRow() / nextRow() methods to RenderTableRow and previousCell() /
nextCell() to RenderTableCell to make traversal code more readable. Also hide
RenderObject's previousSibling() / nextSibling() in those classes to make sure
the more specialized methods are called.

This is based on WebKit r156355 by Antti Koivisto (antti@apple.com):
https://trac.webkit.org/r156355

R=esprehn@chromium.org, pdr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174403

[mstensho (USE GERRIT), 2014-05-20 09:34:39]

Beautiful!

If a table row can contain anything other than cells, or if a table section can
contain anything other than rows, you're introducing assertion failures. But I
honestly don't see why a row/section should contain anything other than
cells/rows (neither per spec nor per implementation), and the addChild() methods
are supposed to make sure it's so.

The only thing I'd like to have resolved is the file header issues.

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
File Source/core/rendering/FixedTableLayout.cpp (right):

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
Source/core/rendering/FixedTableLayout.cpp:4: * Copyright (C) 2003, 2004, 2005,
2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
I think this header should be left alone or replaced completely with:

// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

Can some owners please comment on this?

Anyway, it's not 2013 anymore. :)

You've made this change to quite a few files, but I will refrain from
duplicating this comment at all those instances.

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderBlock.h (right):

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderBlock.h:247: virtual bool nodeAtPoint(const
HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer,
const LayoutPoint& accumulatedOffset, HitTestAction) OVERRIDE;
Right... I see why you need this. I wonder what's the deal with overriding
public methods as protected / private anyway. It's probably nice from some
object-oriented perspective, but most of the time if just causes trouble.

[rune, 2014-05-20 09:45:25]

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
File Source/core/rendering/FixedTableLayout.cpp (right):

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
Source/core/rendering/FixedTableLayout.cpp:4: * Copyright (C) 2003, 2004, 2005,
2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
On 2014/05/20 09:34:39, Morten Stenshorne wrote:
> I think this header should be left alone or replaced completely with:
> 
> // Copyright 2014 The Chromium Authors. All rights reserved.
> // Use of this source code is governed by a BSD-style license that can be
> // found in the LICENSE file.
> 
> Can some owners please comment on this?

New files should use the three-line copyright above, existing files should be
left unchanged:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oSaYHvSLg2M

[Inactive, 2014-05-20 11:32:22]

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
File Source/core/rendering/FixedTableLayout.cpp (right):

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
Source/core/rendering/FixedTableLayout.cpp:4: * Copyright (C) 2003, 2004, 2005,
2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
On 2014/05/20 09:45:25, rune wrote:
> On 2014/05/20 09:34:39, Morten Stenshorne wrote:
> > I think this header should be left alone or replaced completely with:
> > 
> > // Copyright 2014 The Chromium Authors. All rights reserved.
> > // Use of this source code is governed by a BSD-style license that can be
> > // found in the LICENSE file.
> > 
> > Can some owners please comment on this?
> 
> New files should use the three-line copyright above, existing files should be
> left unchanged:
> 
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oSaYHvSLg2M

These are not new files so we cannot use the 3-line copyright as far as I know.
I am porting a patch from Apple that was committed in 2013 so I think updating
the Apple copyright lines to add "2013" is the right thing to do as far as I
know?

[mstensho (USE GERRIT), 2014-05-20 11:35:32]

On 2014/05/20 11:32:22, Chris Dumez wrote:
>
https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
> File Source/core/rendering/FixedTableLayout.cpp (right):
> 
>
https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
> Source/core/rendering/FixedTableLayout.cpp:4: * Copyright (C) 2003, 2004,
2005,
> 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
> On 2014/05/20 09:45:25, rune wrote:
> > On 2014/05/20 09:34:39, Morten Stenshorne wrote:
> > > I think this header should be left alone or replaced completely with:
> > > 
> > > // Copyright 2014 The Chromium Authors. All rights reserved.
> > > // Use of this source code is governed by a BSD-style license that can be
> > > // found in the LICENSE file.
> > > 
> > > Can some owners please comment on this?
> > 
> > New files should use the three-line copyright above, existing files should
be
> > left unchanged:
> > 
> > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oSaYHvSLg2M
> 
> These are not new files so we cannot use the 3-line copyright as far as I
know.
> I am porting a patch from Apple that was committed in 2013 so I think updating
> the Apple copyright lines to add "2013" is the right thing to do as far as I
> know?

I think crediting the original author in the commit (which you did) is good
enough.

[pdr., 2014-05-20 16:49:16]

LGTM

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
File Source/core/rendering/FixedTableLayout.cpp (right):

https://codereview.chromium.org/294783004/diff/40001/Source/core/rendering/Fi...
Source/core/rendering/FixedTableLayout.cpp:4: * Copyright (C) 2003, 2004, 2005,
2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
On 2014/05/20 11:32:23, Chris Dumez wrote:
> On 2014/05/20 09:45:25, rune wrote:
> > On 2014/05/20 09:34:39, Morten Stenshorne wrote:
> > > I think this header should be left alone or replaced completely with:
> > > 
> > > // Copyright 2014 The Chromium Authors. All rights reserved.
> > > // Use of this source code is governed by a BSD-style license that can be
> > > // found in the LICENSE file.
> > > 
> > > Can some owners please comment on this?
> > 
> > New files should use the three-line copyright above, existing files should
be
> > left unchanged:
> > 
> >
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oSaYHvSLg2M
> 
> These are not new files so we cannot use the 3-line copyright as far as I
know.
> I am porting a patch from Apple that was committed in 2013 so I think
updating
> the Apple copyright lines to add "2013" is the right thing to do as far as I
> know?

I think we should move this over as this patch does. Feel free to email
blink-dev for more information though, if you'd like to be on the safe side.

[Inactive, 2014-05-20 20:26:12]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-05-20 20:26:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/294783004/40001

[commit-bot: I haz the power, 2014-05-20 20:39:57]

Change committed as 174403