Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2947463002: [Extensions Bindings] Add a bindings/ subdirectory under renderer (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Add a bindings/ subdirectory under renderer The core bindings system has grown (55 files and 13,000 LOC). Move it to a subdirectory at extensions/renderer/bindings. This also separates out the core bindings system (which is actually extensions-agnostic) from the native extensions binding implementation. Add a DEPS file to enforce this distinction. BUG=653596 Review-Url: https://codereview.chromium.org/2947463002 Cr-Commit-Position: refs/heads/master@{#482024} Committed: https://chromium.googlesource.com/chromium/src/+/d4bcb1e2cf549030d85e0503c0d313f1c70be9cd

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -13048 lines) Patch
M chrome/renderer/extensions/app_hooks_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/app_hooks_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/BUILD.gn View 1 2 3 4 chunks +58 lines, -58 lines 0 comments Download
D extensions/renderer/api_binding.h View 1 2 1 chunk +0 lines, -163 lines 0 comments Download
D extensions/renderer/api_binding.cc View 1 2 1 chunk +0 lines, -633 lines 0 comments Download
D extensions/renderer/api_binding_bridge.h View 1 chunk +0 lines, -63 lines 0 comments Download
D extensions/renderer/api_binding_bridge.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D extensions/renderer/api_binding_hooks.h View 1 chunk +0 lines, -105 lines 0 comments Download
D extensions/renderer/api_binding_hooks.cc View 1 chunk +0 lines, -377 lines 0 comments Download
D extensions/renderer/api_binding_hooks_delegate.h View 1 chunk +0 lines, -45 lines 0 comments Download
D extensions/renderer/api_binding_hooks_delegate.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D extensions/renderer/api_binding_hooks_test_delegate.h View 1 chunk +0 lines, -74 lines 0 comments Download
D extensions/renderer/api_binding_hooks_test_delegate.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D extensions/renderer/api_binding_js_util.h View 1 chunk +0 lines, -108 lines 0 comments Download
D extensions/renderer/api_binding_js_util.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D extensions/renderer/api_binding_js_util_unittest.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D extensions/renderer/api_binding_test.h View 1 chunk +0 lines, -72 lines 0 comments Download
D extensions/renderer/api_binding_test.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D extensions/renderer/api_binding_test_util.h View 1 chunk +0 lines, -130 lines 0 comments Download
D extensions/renderer/api_binding_test_util.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D extensions/renderer/api_binding_types.h View 1 chunk +0 lines, -55 lines 0 comments Download
D extensions/renderer/api_binding_types.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D extensions/renderer/api_binding_unittest.cc View 1 2 1 chunk +0 lines, -1282 lines 0 comments Download
D extensions/renderer/api_bindings_system.h View 1 2 1 chunk +0 lines, -149 lines 0 comments Download
D extensions/renderer/api_bindings_system.cc View 1 2 1 chunk +0 lines, -145 lines 0 comments Download
D extensions/renderer/api_bindings_system_unittest.h View 1 chunk +0 lines, -104 lines 0 comments Download
D extensions/renderer/api_bindings_system_unittest.cc View 1 chunk +0 lines, -479 lines 0 comments Download
D extensions/renderer/api_event_handler.h View 1 chunk +0 lines, -112 lines 0 comments Download
D extensions/renderer/api_event_handler.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D extensions/renderer/api_event_handler_unittest.cc View 1 chunk +0 lines, -1037 lines 0 comments Download
D extensions/renderer/api_event_listeners.h View 1 chunk +0 lines, -169 lines 0 comments Download
D extensions/renderer/api_event_listeners.cc View 1 chunk +0 lines, -273 lines 0 comments Download
D extensions/renderer/api_event_listeners_unittest.cc View 1 2 1 chunk +0 lines, -474 lines 0 comments Download
D extensions/renderer/api_invocation_errors.h View 1 chunk +0 lines, -72 lines 0 comments Download
D extensions/renderer/api_invocation_errors.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D extensions/renderer/api_invocation_errors_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D extensions/renderer/api_last_error.h View 1 chunk +0 lines, -53 lines 0 comments Download
D extensions/renderer/api_last_error.cc View 1 chunk +0 lines, -249 lines 0 comments Download
D extensions/renderer/api_last_error_unittest.cc View 1 chunk +0 lines, -225 lines 0 comments Download
D extensions/renderer/api_request_handler.h View 1 chunk +0 lines, -129 lines 0 comments Download
D extensions/renderer/api_request_handler.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D extensions/renderer/api_request_handler_unittest.cc View 1 chunk +0 lines, -488 lines 0 comments Download
D extensions/renderer/api_signature.h View 1 chunk +0 lines, -80 lines 0 comments Download
D extensions/renderer/api_signature.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D extensions/renderer/api_signature_unittest.cc View 1 chunk +0 lines, -411 lines 0 comments Download
D extensions/renderer/api_type_reference_map.h View 1 chunk +0 lines, -75 lines 0 comments Download
D extensions/renderer/api_type_reference_map.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D extensions/renderer/argument_spec.h View 1 chunk +0 lines, -182 lines 0 comments Download
D extensions/renderer/argument_spec.cc View 1 chunk +0 lines, -643 lines 0 comments Download
D extensions/renderer/argument_spec_builder.h View 1 chunk +0 lines, -50 lines 0 comments Download
D extensions/renderer/argument_spec_builder.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D extensions/renderer/argument_spec_unittest.cc View 1 chunk +0 lines, -817 lines 0 comments Download
D extensions/renderer/binding_access_checker.h View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
D extensions/renderer/binding_access_checker.cc View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D extensions/renderer/binding_access_checker_unittest.cc View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
A extensions/renderer/bindings/DEPS View 1 1 chunk +25 lines, -0 lines 0 comments Download
A extensions/renderer/bindings/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/renderer/bindings/api_binding.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/api_binding.cc View 1 2 2 chunks +10 lines, -12 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_bridge.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_bridge.cc View 3 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_hooks.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_hooks.cc View 3 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_hooks_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_hooks_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_binding_hooks_test_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_hooks_test_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_binding_js_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_js_util.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_js_util_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_test.h View 3 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_test.cc View 3 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_binding_test_util.h View 3 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_binding_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_binding_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_binding_unittest.cc View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
A + extensions/renderer/bindings/api_bindings_system.h View 1 2 3 3 chunks +10 lines, -10 lines 0 comments Download
A + extensions/renderer/bindings/api_bindings_system.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/renderer/bindings/api_bindings_system_unittest.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + extensions/renderer/bindings/api_bindings_system_unittest.cc View 3 2 chunks +8 lines, -9 lines 0 comments Download
A + extensions/renderer/bindings/api_event_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/renderer/bindings/api_event_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_event_handler_unittest.cc View 3 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_event_listeners.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/api_event_listeners.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_event_listeners_unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/api_invocation_errors.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_invocation_errors.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_invocation_errors_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_last_error.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_last_error.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_last_error_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_request_handler.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/renderer/bindings/api_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/api_request_handler_unittest.cc View 3 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_signature.h View 3 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_signature.cc View 3 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_signature_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + extensions/renderer/bindings/api_type_reference_map.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/api_type_reference_map.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/argument_spec.h View 3 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/argument_spec.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/argument_spec_builder.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/argument_spec_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/argument_spec_unittest.cc View 3 1 chunk +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/binding_access_checker.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/binding_access_checker.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/bindings/binding_access_checker_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/renderer/bindings/declarative_event.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/bindings/declarative_event.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + extensions/renderer/bindings/declarative_event_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
A + extensions/renderer/bindings/event_emitter.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/renderer/bindings/event_emitter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/renderer/bindings/event_emitter_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/renderer/chrome_setting.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/chrome_setting.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/renderer/content_setting.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/content_setting.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/renderer/declarative_content_hooks_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/declarative_content_hooks_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D extensions/renderer/declarative_event.h View 1 chunk +0 lines, -63 lines 0 comments Download
D extensions/renderer/declarative_event.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D extensions/renderer/declarative_event_unittest.cc View 1 chunk +0 lines, -258 lines 0 comments Download
D extensions/renderer/event_emitter.h View 1 chunk +0 lines, -85 lines 0 comments Download
D extensions/renderer/event_emitter.cc View 1 chunk +0 lines, -198 lines 0 comments Download
D extensions/renderer/event_emitter_unittest.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/storage_area.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/renderer/web_request_hooks.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/web_request_hooks.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (17 generated)
Devlin
Hey folks, mind taking a look? This is purely moving files with the exception of ...
3 years, 6 months ago (2017-06-16 22:25:13 UTC) #5
jbroman
lgtm https://codereview.chromium.org/2947463002/diff/20001/extensions/renderer/bindings/OWNERS File extensions/renderer/bindings/OWNERS (right): https://codereview.chromium.org/2947463002/diff/20001/extensions/renderer/bindings/OWNERS#newcode3 extensions/renderer/bindings/OWNERS:3: jbroman@chromium.org On 2017/06/16 at 22:25:13, Devlin wrote: > ...
3 years, 6 months ago (2017-06-20 19:55:41 UTC) #8
lazyboy
Thanks, lgtm.
3 years, 6 months ago (2017-06-23 07:33:28 UTC) #9
Devlin
https://codereview.chromium.org/2947463002/diff/20001/extensions/renderer/bindings/OWNERS File extensions/renderer/bindings/OWNERS (right): https://codereview.chromium.org/2947463002/diff/20001/extensions/renderer/bindings/OWNERS#newcode3 extensions/renderer/bindings/OWNERS:3: jbroman@chromium.org On 2017/06/20 19:55:41, jbroman wrote: > On 2017/06/16 ...
3 years, 6 months ago (2017-06-23 20:52:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947463002/80001
3 years, 6 months ago (2017-06-23 20:53:35 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 21:01:20 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d4bcb1e2cf549030d85e0503c0d3...

Powered by Google App Engine
This is Rietveld 408576698