Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: extensions/renderer/binding_access_checker_unittest.cc

Issue 2947463002: [Extensions Bindings] Add a bindings/ subdirectory under renderer (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/binding_access_checker.cc ('k') | extensions/renderer/bindings/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/binding_access_checker_unittest.cc
diff --git a/extensions/renderer/binding_access_checker_unittest.cc b/extensions/renderer/binding_access_checker_unittest.cc
deleted file mode 100644
index cba77bb956484d8d0a52140f1507b8e8363020cc..0000000000000000000000000000000000000000
--- a/extensions/renderer/binding_access_checker_unittest.cc
+++ /dev/null
@@ -1,56 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "extensions/renderer/binding_access_checker.h"
-
-#include "base/bind.h"
-#include "extensions/renderer/api_binding_test.h"
-#include "gin/converter.h"
-
-namespace extensions {
-
-namespace {
-
-bool IsAvailable(v8::Local<v8::Context> context, const std::string& full_name) {
- EXPECT_TRUE(full_name == "available" || full_name == "unavailable")
- << full_name;
- return full_name == "available";
-}
-
-} // namespace
-
-using BindingAccessCheckerTest = APIBindingTest;
-
-TEST_F(BindingAccessCheckerTest, TestHasAccess) {
- v8::HandleScope handle_scope(isolate());
-
- BindingAccessChecker checker(base::Bind(&IsAvailable));
-
- v8::Local<v8::Context> context = MainContext();
- EXPECT_TRUE(checker.HasAccess(context, "available"));
- EXPECT_FALSE(checker.HasAccess(context, "unavailable"));
-}
-
-TEST_F(BindingAccessCheckerTest, TestHasAccessOrThrowError) {
- v8::HandleScope handle_scope(isolate());
-
- BindingAccessChecker checker(base::Bind(&IsAvailable));
-
- v8::Local<v8::Context> context = MainContext();
- {
- v8::TryCatch try_catch(isolate());
- EXPECT_TRUE(checker.HasAccessOrThrowError(context, "available"));
- EXPECT_FALSE(try_catch.HasCaught());
- }
-
- {
- v8::TryCatch try_catch(isolate());
- EXPECT_FALSE(checker.HasAccessOrThrowError(context, "unavailable"));
- ASSERT_TRUE(try_catch.HasCaught());
- EXPECT_EQ("Uncaught Error: 'unavailable' is not available in this context.",
- gin::V8ToString(try_catch.Message()->Get()));
- }
-}
-
-} // namespace extensions
« no previous file with comments | « extensions/renderer/binding_access_checker.cc ('k') | extensions/renderer/bindings/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698