Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: extensions/renderer/api_binding_bridge.cc

Issue 2947463002: [Extensions Bindings] Add a bindings/ subdirectory under renderer (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_binding_bridge.h ('k') | extensions/renderer/api_binding_hooks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_bridge.cc
diff --git a/extensions/renderer/api_binding_bridge.cc b/extensions/renderer/api_binding_bridge.cc
deleted file mode 100644
index 380734992aa3b9db8d7580a32bb511a866530950..0000000000000000000000000000000000000000
--- a/extensions/renderer/api_binding_bridge.cc
+++ /dev/null
@@ -1,105 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "extensions/renderer/api_binding_bridge.h"
-
-#include "base/values.h"
-#include "extensions/renderer/api_binding_hooks.h"
-#include "gin/converter.h"
-#include "gin/object_template_builder.h"
-
-namespace extensions {
-
-namespace {
-
-const char kApiObjectKey[] = "extensions::bridge::api_object";
-const char kHookInterfaceKey[] = "extensions::bridge::hook_object";
-
-v8::Local<v8::Private> GetPrivatePropertyName(v8::Isolate* isolate,
- const char* key) {
- return v8::Private::ForApi(isolate, gin::StringToSymbol(isolate, key));
-}
-
-} // namespace
-
-gin::WrapperInfo APIBindingBridge::kWrapperInfo = {gin::kEmbedderNativeGin};
-
-APIBindingBridge::APIBindingBridge(APIBindingHooks* hooks,
- v8::Local<v8::Context> context,
- v8::Local<v8::Value> api_object,
- const std::string& extension_id,
- const std::string& context_type,
- const binding::RunJSFunction& run_js)
- : extension_id_(extension_id),
- context_type_(context_type),
- run_js_(run_js) {
- v8::Isolate* isolate = context->GetIsolate();
- v8::Local<v8::Object> wrapper = GetWrapper(isolate).ToLocalChecked();
- v8::Maybe<bool> result = wrapper->SetPrivate(
- context, GetPrivatePropertyName(isolate, kApiObjectKey), api_object);
- if (!result.IsJust() || !result.FromJust()) {
- NOTREACHED();
- return;
- }
- v8::Local<v8::Object> js_hook_interface = hooks->GetJSHookInterface(context);
- result = wrapper->SetPrivate(context,
- GetPrivatePropertyName(isolate,
- kHookInterfaceKey),
- js_hook_interface);
- DCHECK(result.IsJust() && result.FromJust());
-}
-
-APIBindingBridge::~APIBindingBridge() {}
-
-gin::ObjectTemplateBuilder APIBindingBridge::GetObjectTemplateBuilder(
- v8::Isolate* isolate) {
- return Wrappable<APIBindingBridge>::GetObjectTemplateBuilder(isolate)
- .SetMethod("registerCustomHook", &APIBindingBridge::RegisterCustomHook);
-}
-
-void APIBindingBridge::RegisterCustomHook(v8::Isolate* isolate,
- v8::Local<v8::Function> function) {
- // The object and arguments here are meant to match those passed to the hook
- // functions in binding.js.
- v8::Local<v8::Context> context = isolate->GetCurrentContext();
- v8::Local<v8::Object> hook_object = v8::Object::New(isolate);
- v8::Local<v8::Object> wrapper;
- if (!GetWrapper(isolate).ToLocal(&wrapper))
- return;
-
- v8::Local<v8::Value> hook_interface =
- wrapper->GetPrivate(
- context, GetPrivatePropertyName(isolate, kHookInterfaceKey))
- .ToLocalChecked();
- v8::Maybe<bool> result = hook_object->CreateDataProperty(
- context, gin::StringToSymbol(isolate, "apiFunctions"), hook_interface);
- if (!result.IsJust() || !result.FromJust())
- return;
-
- v8::Local<v8::Value> api_object =
- wrapper
- ->GetPrivate(context, GetPrivatePropertyName(isolate, kApiObjectKey))
- .ToLocalChecked();
- result = hook_object->CreateDataProperty(
- context, gin::StringToSymbol(isolate, "compiledApi"), api_object);
- if (!result.IsJust() || !result.FromJust())
- return;
-
- // TODO(devlin): The binding.js version of these hooks also has a 'schema'
- // property. I wonder if we can factor that out? If not, we'll need to add it
- // here.
-
- result = hook_object->SetPrototype(context, v8::Null(isolate));
- if (!result.IsJust() || !result.FromJust())
- return;
-
- v8::Local<v8::String> extension_id =
- gin::StringToSymbol(isolate, extension_id_);
- v8::Local<v8::String> context_type =
- gin::StringToSymbol(isolate, context_type_);
- v8::Local<v8::Value> args[] = {hook_object, extension_id, context_type};
- run_js_.Run(function, context, arraysize(args), args);
-}
-
-} // namespace extensions
« no previous file with comments | « extensions/renderer/api_binding_bridge.h ('k') | extensions/renderer/api_binding_hooks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698