Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: extensions/renderer/api_request_handler.h

Issue 2947463002: [Extensions Bindings] Add a bindings/ subdirectory under renderer (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_last_error_unittest.cc ('k') | extensions/renderer/api_request_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_request_handler.h
diff --git a/extensions/renderer/api_request_handler.h b/extensions/renderer/api_request_handler.h
deleted file mode 100644
index 10ede6877ee41e90c25c68e55294ae0923375ad6..0000000000000000000000000000000000000000
--- a/extensions/renderer/api_request_handler.h
+++ /dev/null
@@ -1,129 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef EXTENSIONS_RENDERER_API_REQUEST_HANDLER_H_
-#define EXTENSIONS_RENDERER_API_REQUEST_HANDLER_H_
-
-#include <map>
-#include <memory>
-#include <set>
-
-#include "base/callback.h"
-#include "base/macros.h"
-#include "extensions/renderer/api_binding_types.h"
-#include "extensions/renderer/api_last_error.h"
-#include "third_party/WebKit/public/web/WebUserGestureToken.h"
-#include "v8/include/v8.h"
-
-namespace base {
-class ListValue;
-}
-
-namespace extensions {
-
-// A wrapper around a map for extension API calls. Contains all pending requests
-// and the associated context and callback. Designed to be used on a single
-// thread, but amongst multiple contexts.
-class APIRequestHandler {
- public:
- // TODO(devlin): We may want to coalesce this with the
- // ExtensionHostMsg_Request_Params IPC struct.
- struct Request {
- Request();
- ~Request();
-
- int request_id = -1;
- std::string method_name;
- bool has_callback = false;
- bool has_user_gesture = false;
- binding::RequestThread thread = binding::RequestThread::UI;
- std::unique_ptr<base::ListValue> arguments;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(Request);
- };
-
- using SendRequestMethod =
- base::Callback<void(std::unique_ptr<Request>, v8::Local<v8::Context>)>;
-
- using CallJSFunction = base::Callback<void(v8::Local<v8::Function>,
- v8::Local<v8::Context>,
- int argc,
- v8::Local<v8::Value>[])>;
-
- APIRequestHandler(const SendRequestMethod& send_request,
- const CallJSFunction& call_js,
- APILastError last_error);
- ~APIRequestHandler();
-
- // Begins the process of processing the request. Returns the identifier of the
- // pending request, or -1 if no pending request was added (which can happen if
- // no callback was specified).
- int StartRequest(v8::Local<v8::Context> context,
- const std::string& method,
- std::unique_ptr<base::ListValue> arguments,
- v8::Local<v8::Function> callback,
- v8::Local<v8::Function> custom_callback,
- binding::RequestThread thread);
-
- // Adds a pending request for the request handler to manage (and complete via
- // CompleteRequest). This is used by renderer-side implementations that
- // shouldn't be dispatched to the browser in the normal flow, but means other
- // classes don't have to worry about context invalidation.
- int AddPendingRequest(v8::Local<v8::Context> context,
- v8::Local<v8::Function> callback);
-
- // Responds to the request with the given |request_id|, calling the callback
- // with the given |response| arguments.
- // Invalid ids are ignored.
- void CompleteRequest(int request_id,
- const base::ListValue& response,
- const std::string& error);
-
- // Invalidates any requests that are associated with |context|.
- void InvalidateContext(v8::Local<v8::Context> context);
-
- APILastError* last_error() { return &last_error_; }
-
- std::set<int> GetPendingRequestIdsForTesting() const;
-
- private:
- struct PendingRequest {
- PendingRequest(v8::Isolate* isolate,
- v8::Local<v8::Function> callback,
- v8::Local<v8::Context> context,
- const std::vector<v8::Local<v8::Value>>& callback_args);
- ~PendingRequest();
- PendingRequest(PendingRequest&&);
- PendingRequest& operator=(PendingRequest&&);
-
- v8::Isolate* isolate;
- v8::Global<v8::Context> context;
- v8::Global<v8::Function> callback;
- std::vector<v8::Global<v8::Value>> callback_arguments;
- blink::WebUserGestureToken user_gesture_token;
- };
-
- // The next available request identifier.
- int next_request_id_ = 0;
-
- // A map of all pending requests.
- std::map<int, PendingRequest> pending_requests_;
-
- SendRequestMethod send_request_;
-
- // The method to call into a JS with specific arguments. We curry this in
- // because the manner we want to do this is a unittest (e.g.
- // v8::Function::Call) can be significantly different than in production
- // (where we have to deal with e.g. blocking javascript).
- CallJSFunction call_js_;
-
- APILastError last_error_;
-
- DISALLOW_COPY_AND_ASSIGN(APIRequestHandler);
-};
-
-} // namespace extensions
-
-#endif // EXTENSIONS_RENDERER_API_REQUEST_HANDLER_H_
« no previous file with comments | « extensions/renderer/api_last_error_unittest.cc ('k') | extensions/renderer/api_request_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698