Remove gfx::DIAGONAL_STRIKE and supporting code.

Remove gfx::DIAGONAL_STRIKE and supporting code.

The diagonal strikethrough was only used for the omnibox on some platforms. Based on a user study, we are switching them to horizontal strikethroughs: https://bugs.chromium.org/p/chromium/issues/detail?id=528104#c21
This leaves no remaining use cases for the diagonal strike.

BUG=734258
Review-Url: https://codereview.chromium.org/2943823002
Cr-Commit-Position: refs/heads/master@{#480668}
Committed: https://chromium.googlesource.com/chromium/src/+/cbac25a432e85afc77b6696c21d6216cbc225b39

[lgarron, 2017-06-17 00:03:13]

lgarron@chromium.org changed reviewers:
+ asvitkine@chromium.org, tapted@chromium.org

[lgarron, 2017-06-17 00:03:14]

asvitkine@, could you review ui/gfx?
tapted@, could you review ui/views/examples?

[lgarron, 2017-06-17 00:03:29]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-17 00:03:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-06-17 00:08:47]

Description was changed from

==========
Remove gfx::DIAGONAL_STRIKE and supporting code.

BUG=734258
==========

to

==========
Remove gfx::DIAGONAL_STRIKE and supporting code.

The diagonal strikethrough was only used for the omnibox on some platforms.
Based on a user study, we switched them to horizontal strikethroughs:
https://bugs.chromium.org/p/chromium/issues/detail?id=528104#c21
This leaves no remaining use cases for the diagonal strike.

BUG=734258
==========

[lgarron, 2017-06-17 00:09:06]

Description was changed from

==========
Remove gfx::DIAGONAL_STRIKE and supporting code.

The diagonal strikethrough was only used for the omnibox on some platforms.
Based on a user study, we switched them to horizontal strikethroughs:
https://bugs.chromium.org/p/chromium/issues/detail?id=528104#c21
This leaves no remaining use cases for the diagonal strike.

BUG=734258
==========

to

==========
Remove gfx::DIAGONAL_STRIKE and supporting code.

The diagonal strikethrough was only used for the omnibox on some platforms.
Based on a user study, we are switching them to horizontal strikethroughs:
https://bugs.chromium.org/p/chromium/issues/detail?id=528104#c21
This leaves no remaining use cases for the diagonal strike.

BUG=734258
==========

[commit-bot: I haz the power, 2017-06-17 01:25:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 01:25:34]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-06-19 00:14:42]

ui/views/examples lgtm

[Alexei Svitkine (slow), 2017-06-19 14:47:33]

lgtm, thanks for the cleanup

[lgarron, 2017-06-19 22:02:37]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-06-19 22:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 22:03:03]

This CL has an open dependency (Issue 1302223010 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[lgarron, 2017-06-19 22:47:19]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-06-19 22:47:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 00:57:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497912439521920, "parent_rev":
"8a0e66638576682a63c60739dac04f53491c2785", "commit_rev":
"cbac25a432e85afc77b6696c21d6216cbc225b39"}

[commit-bot: I haz the power, 2017-06-20 00:57:42]

Description was changed from

==========
Remove gfx::DIAGONAL_STRIKE and supporting code.

The diagonal strikethrough was only used for the omnibox on some platforms.
Based on a user study, we are switching them to horizontal strikethroughs:
https://bugs.chromium.org/p/chromium/issues/detail?id=528104#c21
This leaves no remaining use cases for the diagonal strike.

BUG=734258
==========

to

==========
Remove gfx::DIAGONAL_STRIKE and supporting code.

The diagonal strikethrough was only used for the omnibox on some platforms.
Based on a user study, we are switching them to horizontal strikethroughs:
https://bugs.chromium.org/p/chromium/issues/detail?id=528104#c21
This leaves no remaining use cases for the diagonal strike.

BUG=734258

Review-Url: https://codereview.chromium.org/2943823002
Cr-Commit-Position: refs/heads/master@{#480668}
Committed:
https://chromium.googlesource.com/chromium/src/+/cbac25a432e85afc77b6696c21d6...
==========

[commit-bot: I haz the power, 2017-06-20 00:57:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbac25a432e85afc77b6696c21d6...