Make https omnibox strikethrough horizontal on all platforms.

Make https omnibox strikethrough horizontal on all platforms.


This changes Views and WebVR implementations from diagonal to horizontal.

BUG=528104
Review-Url: https://codereview.chromium.org/1302223010
Cr-Commit-Position: refs/heads/master@{#480607}
Committed: https://chromium.googlesource.com/chromium/src/+/b7a10307adc3941fd7319bf325e687707e185fc2

[lgarron, 2015-09-04 18:01:15]

lgarron@chromium.org changed reviewers:
+ pkasting@chromium.org

[lgarron, 2015-09-04 18:01:16]

pkasting@, could you review?

[Peter Kasting, 2015-09-04 21:02:26]

I think this change is wrong.  Commented on the bug.

[lgarron, 2015-09-05 00:32:04]

Closing. Thanks for commenting in the issue, pkasting@.

[lgarron, 2017-06-16 21:17:01]

pkasting@, in light of crbug.com/528104 could you re-review?

[lgarron, 2017-06-16 21:19:12]

Description was changed from

==========
Change the https strikethrough for Windows and Linux to be horizontal.

This changes the Views omnibox implementation.

BUG=528104
==========

to

==========
Change the https strikethrough for Views to horizontal.

This changes the Views omnibox implementation.

BUG=528104
==========

[lgarron, 2017-06-16 21:23:06]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 21:23:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-06-16 21:23:39]

Description was changed from

==========
Change the https strikethrough for Views to horizontal.

This changes the Views omnibox implementation.

BUG=528104
==========

to

==========
Change the https strikethrough for in the Views omnibox to horizontal.

BUG=528104
==========

[commit-bot: I haz the power, 2017-06-16 21:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 21:25:57]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lgarron, 2017-06-16 21:44:40]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 21:45:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-06-16 22:46:17]

It looks like the omnibox, and the VR version of the omnibox, are the only
places we use the diagonal strike implementation.  Can you go ahead and rip the
whole thing out?

[commit-bot: I haz the power, 2017-06-16 22:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 22:58:33]

Dry run: This issue passed the CQ dry run.

[lgarron, 2017-06-16 23:21:49]

Description was changed from

==========
Change the https strikethrough for in the Views omnibox to horizontal.

BUG=528104
==========

to

==========
Make https omnibox strikethrough horizontal on all platforms.


This changes Views and WebVR implementations from diagonal to horizontal.

BUG=528104
==========

[lgarron, 2017-06-16 23:21:58]

Done!

[lgarron, 2017-06-16 23:22:00]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 23:22:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-06-16 23:23:35]

On 2017/06/16 at 23:21:58, lgarron wrote:
> Done!

Actually, on second reading maybe you meant all gfx::DIAGONAL_STRIKE support
code?

[Peter Kasting, 2017-06-16 23:24:21]

On 2017/06/16 23:23:35, lgarron wrote:
> On 2017/06/16 at 23:21:58, lgarron wrote:
> > Done!
> 
> Actually, on second reading maybe you meant all gfx::DIAGONAL_STRIKE support
> code?

Yes.  I was surprised you got this done so fast :)

[lgarron, 2017-06-16 23:35:23]

On 2017/06/16 at 23:24:21, pkasting wrote:
> On 2017/06/16 23:23:35, lgarron wrote:
> > On 2017/06/16 at 23:21:58, lgarron wrote:
> > > Done!
> > 
> > Actually, on second reading maybe you meant all gfx::DIAGONAL_STRIKE support
> > code?
> 
> Yes.  I was surprised you got this done so fast :)

Alright, I have a follow-up bug at
https://bugs.chromium.org/p/chromium/issues/detail?id=734258
I'll try to go implement it right now.

[Peter Kasting, 2017-06-16 23:44:55]

LGTM on this then

[commit-bot: I haz the power, 2017-06-17 00:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:43:15]

Dry run: This issue passed the CQ dry run.

[lgarron, 2017-06-17 00:50:39]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:50:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 01:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 01:02:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lgarron, 2017-06-17 01:02:59]

lgarron@chromium.org changed reviewers:
+ cjgrant@chromium.org

[lgarron, 2017-06-17 01:03:00]

cjgrant@, could you review the VR shell code?

[cjgrant, 2017-06-19 13:51:37]

lgtm

[lgarron, 2017-06-19 21:11:33]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-06-19 21:12:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 22:41:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497906693671090,
"parent_rev": "c8a2d7b5079af3150a0453adf6e36436914bbc7e", "commit_rev":
"b7a10307adc3941fd7319bf325e687707e185fc2"}

[commit-bot: I haz the power, 2017-06-19 22:41:51]

Description was changed from

==========
Make https omnibox strikethrough horizontal on all platforms.


This changes Views and WebVR implementations from diagonal to horizontal.

BUG=528104
==========

to

==========
Make https omnibox strikethrough horizontal on all platforms.


This changes Views and WebVR implementations from diagonal to horizontal.

BUG=528104

Review-Url: https://codereview.chromium.org/1302223010
Cr-Commit-Position: refs/heads/master@{#480607}
Committed:
https://chromium.googlesource.com/chromium/src/+/b7a10307adc3941fd7319bf325e6...
==========

[commit-bot: I haz the power, 2017-06-19 22:41:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b7a10307adc3941fd7319bf325e6...