Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2943823002: Remove gfx::DIAGONAL_STRIKE and supporting code. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text_harfbuzz.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index 912ebb2e555962bace34df0facaeb2590dedac04..001d47055f857fae3c5be2abcc96677d7f3bfabc 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -658,7 +658,6 @@ TextRunHarfBuzz::TextRunHarfBuzz(const Font& template_font)
italic(false),
weight(Font::Weight::NORMAL),
strike(false),
- diagonal_strike(false),
underline(false) {}
TextRunHarfBuzz::~TextRunHarfBuzz() {}
@@ -1326,15 +1325,12 @@ void RenderTextHarfBuzz::DrawVisualText(internal::SkiaTextRenderer* renderer) {
SkIntToScalar(origin.x()))
: positions[colored_glyphs.end() - glyphs_range.start()].x());
renderer->DrawDecorations(start_x, origin.y(), end_x - start_x,
- run.underline, run.strike,
- run.diagonal_strike);
+ run.underline, run.strike);
}
preceding_segment_widths += SkFloatToScalar(segment.width());
}
}
- renderer->EndDiagonalStrike();
-
UndoCompositionAndSelectionStyles();
}
@@ -1403,7 +1399,6 @@ void RenderTextHarfBuzz::ItemizeTextToRuns(
run->italic = style.style(ITALIC);
run->baseline_type = style.baseline();
run->strike = style.style(STRIKE);
- run->diagonal_strike = style.style(DIAGONAL_STRIKE);
run->underline = style.style(UNDERLINE);
run->weight = style.weight();
int32_t script_item_break = 0;
@@ -1730,7 +1725,6 @@ bool RenderTextHarfBuzz::GetDecoratedTextForRange(
run.font.Derive(0, style, run.weight));
attribute.strike = run.strike;
- attribute.diagonal_strike = run.diagonal_strike;
decorated_text->attributes.push_back(attribute);
}
}
« no previous file with comments | « ui/gfx/render_text_harfbuzz.h ('k') | ui/gfx/render_text_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698