Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: ui/gfx/render_text_unittest.cc

Issue 2943823002: Remove gfx::DIAGONAL_STRIKE and supporting code. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text_mac.mm ('k') | ui/gfx/text_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_unittest.cc
diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc
index a3fef5cabc2c623af3da03340770de7fbefd1a26..d64f3df85c5461d8650a52d1d31923fd154ca829 100644
--- a/ui/gfx/render_text_unittest.cc
+++ b/ui/gfx/render_text_unittest.cc
@@ -165,7 +165,6 @@ const wchar_t kRtlLtrRtl[] = L"\x5d0" L"a" L"\x5d1";
enum {
ITALIC_MASK = 1 << ITALIC,
STRIKE_MASK = 1 << STRIKE,
- DIAGONAL_STRIKE_MASK = 1 << DIAGONAL_STRIKE,
UNDERLINE_MASK = 1 << UNDERLINE,
};
@@ -251,7 +250,6 @@ DecoratedText::RangedAttribute CreateRangedAttribute(
DecoratedText::RangedAttribute attributes(Range(index, index + 1),
font_with_style);
attributes.strike = style_mask & STRIKE_MASK;
- attributes.diagonal_strike = style_mask & DIAGONAL_STRIKE_MASK;
return attributes;
}
@@ -280,7 +278,6 @@ void VerifyDecoratedWordsAreEqual(const DecoratedText& expected,
ASSERT_NE(actual.attributes.end(), actual_attr);
EXPECT_EQ(expected_attr->strike, actual_attr->strike);
- EXPECT_EQ(expected_attr->diagonal_strike, actual_attr->diagonal_strike);
EXPECT_EQ(expected_attr->font.GetFontName(),
actual_attr->font.GetFontName());
EXPECT_EQ(expected_attr->font.GetFontSize(),
@@ -317,16 +314,13 @@ class TestSkiaTextRenderer : public internal::SkiaTextRenderer {
};
struct DecorationLog {
- DecorationLog(int x, int y, int width, bool underline, bool strike,
- bool diagonal_strike)
- : x(x), y(y), width(width), underline(underline), strike(strike),
- diagonal_strike(diagonal_strike) {}
+ DecorationLog(int x, int y, int width, bool underline, bool strike)
+ : x(x), y(y), width(width), underline(underline), strike(strike) {}
int x;
int y;
int width;
bool underline;
bool strike;
- bool diagonal_strike;
};
explicit TestSkiaTextRenderer(Canvas* canvas)
@@ -364,12 +358,13 @@ class TestSkiaTextRenderer : public internal::SkiaTextRenderer {
internal::SkiaTextRenderer::DrawPosText(pos, glyphs, glyph_count);
}
- void DrawDecorations(int x, int y, int width, bool underline, bool strike,
- bool diagonal_strike) override {
- decoration_log_.push_back(
- DecorationLog(x, y, width, underline, strike, diagonal_strike));
- internal::SkiaTextRenderer::DrawDecorations(
- x, y, width, underline, strike, diagonal_strike);
+ void DrawDecorations(int x,
+ int y,
+ int width,
+ bool underline,
+ bool strike) override {
+ decoration_log_.push_back(DecorationLog(x, y, width, underline, strike));
+ internal::SkiaTextRenderer::DrawDecorations(x, y, width, underline, strike);
}
std::vector<TextLog> text_log_;
@@ -1056,7 +1051,6 @@ TEST_P(RenderTextHarfBuzzTest, MultilineElide) {
// slightly different width. This must be done after |SetText()|.
render_text->ApplyWeight(Font::Weight::BOLD, Range(1, 20));
render_text->ApplyStyle(ITALIC, true, Range(1, 20));
- render_text->ApplyStyle(DIAGONAL_STRIKE, true, Range(1, 20));
render_text->SetMultiline(true);
render_text->SetElideBehavior(ELIDE_TAIL);
render_text->SetMaxLines(3);
@@ -4071,7 +4065,6 @@ TEST_P(RenderTextHarfBuzzTest, GetDecoratedWordAtPoint_LTR) {
render_text->ApplyWeight(Font::Weight::SEMIBOLD, Range(0, 3));
render_text->ApplyStyle(UNDERLINE, true, Range(1, 5));
render_text->ApplyStyle(ITALIC, true, Range(3, 8));
- render_text->ApplyStyle(DIAGONAL_STRIKE, true, Range(5, 7));
render_text->ApplyStyle(STRIKE, true, Range(1, 7));
const int cursor_y = GetCursorYForTesting();
@@ -4095,9 +4088,9 @@ TEST_P(RenderTextHarfBuzzTest, GetDecoratedWordAtPoint_LTR) {
DecoratedText expected_word_2;
expected_word_2.text = ASCIIToUTF16("c");
// Attributes for character 'c' at logical index |kWordTwoStartIndex|.
- expected_word_2.attributes.push_back(CreateRangedAttribute(
- font_spans, 0, kWordTwoStartIndex, Font::Weight::NORMAL,
- ITALIC_MASK | DIAGONAL_STRIKE_MASK | STRIKE_MASK));
+ expected_word_2.attributes.push_back(
+ CreateRangedAttribute(font_spans, 0, kWordTwoStartIndex,
+ Font::Weight::NORMAL, ITALIC_MASK | STRIKE_MASK));
const Rect left_glyph_word_2 = render_text->GetCursorBounds(
SelectionModel(kWordTwoStartIndex, CURSOR_FORWARD), false);
@@ -4156,7 +4149,6 @@ TEST_P(RenderTextHarfBuzzTest, GetDecoratedWordAtPoint_RTL) {
render_text->ApplyWeight(Font::Weight::SEMIBOLD, Range(2, 3));
render_text->ApplyStyle(UNDERLINE, true, Range(3, 6));
render_text->ApplyStyle(ITALIC, true, Range(0, 3));
- render_text->ApplyStyle(DIAGONAL_STRIKE, true, Range(0, 2));
render_text->ApplyStyle(STRIKE, true, Range(2, 5));
const int cursor_y = GetCursorYForTesting();
@@ -4168,8 +4160,7 @@ TEST_P(RenderTextHarfBuzzTest, GetDecoratedWordAtPoint_RTL) {
expected_word_1.text = WideToUTF16(L"\x0634\x0632");
// Attributes for characters at logical indices 1 and 2.
expected_word_1.attributes.push_back(CreateRangedAttribute(
- font_spans, 0, kWordOneStartIndex, Font::Weight::NORMAL,
- ITALIC_MASK | DIAGONAL_STRIKE_MASK));
+ font_spans, 0, kWordOneStartIndex, Font::Weight::NORMAL, ITALIC_MASK));
expected_word_1.attributes.push_back(
CreateRangedAttribute(font_spans, 1, kWordOneStartIndex + 1,
Font::Weight::SEMIBOLD, ITALIC_MASK | STRIKE_MASK));
« no previous file with comments | « ui/gfx/render_text_mac.mm ('k') | ui/gfx/text_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698