Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2941763004: Explicitly setting names for stories in unittests (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly setting names for stories in unittests BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2941763004 Cr-Commit-Position: refs/heads/master@{#479522} Committed: https://chromium.googlesource.com/chromium/src/+/bf5b209144b31ec31a8b6f2938d68a12b19a38d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M tools/perf/benchmarks/blink_perf_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/contrib/cluster_telemetry/page_set.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/task_execution_time_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/v8_gc_times_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ashleymarie1
3 years, 6 months ago (2017-06-14 20:34:08 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-14 20:46:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941763004/1
3 years, 6 months ago (2017-06-14 20:47:11 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 22:17:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf5b209144b31ec31a8b6f2938d6...

Powered by Google App Engine
This is Rietveld 408576698