Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py

Issue 2941763004: Explicitly setting names for stories in unittests (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py
diff --git a/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py b/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py
index a559785d985e35f0942fe7a3c5c83079795d09d3..0f93ec855d069d0f902ca765575a7853dce049c6 100644
--- a/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py
+++ b/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py
@@ -14,7 +14,7 @@ from measurements import v8_detached_context_age_in_gc
class FakePage(page_module.Page):
def __init__(self, url):
- super(FakePage, self).__init__(url=url)
+ super(FakePage, self).__init__(url=url, name=url)
@property
def is_file(self):
@@ -58,7 +58,7 @@ class SimplePage(page_module.Page):
def __init__(self, page_set):
super(SimplePage, self).__init__(
- 'file://host.html', page_set, page_set.base_dir)
+ 'file://host.html', page_set, page_set.base_dir, name='host.html')
def RunPageInteractions(self, action_runner):
# Reload the page to detach the previous context.
« no previous file with comments | « tools/perf/measurements/task_execution_time_unittest.py ('k') | tools/perf/measurements/v8_gc_times_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698