tools/perf/measurements/v8_gc_times_unittest.py - Issue 2941763004: Explicitly setting names for stories in unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/v8_gc_times_unittest.py

Issue 2941763004: Explicitly setting names for stories in unittests (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/v8_gc_times_unittest.py

diff --git a/tools/perf/measurements/v8_gc_times_unittest.py b/tools/perf/measurements/v8_gc_times_unittest.py

index 5610fb4d4595f4c7da335debdf5f52030de494c2..b08226dfc7cfa60bd4d9e1f3667540710875c26d 100644

--- a/tools/perf/measurements/v8_gc_times_unittest.py

+++ b/tools/perf/measurements/v8_gc_times_unittest.py

@@ -35,7 +35,7 @@ class V8GCTimesTestPageHelper(object):

def __init__(self, page_set):

super(V8GCTimesTestPageHelper.MockV8GCTimesPage, self).__init__(

- 'file://blank.html', page_set, page_set.base_dir)

+ 'file://blank.html', page_set, page_set.base_dir, name='blank.html')

def MeasureFakePage(self):

# Create a fake page and add it to the page set.

« no previous file with comments | « tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py ('k') | no next file » | no next file with comments »