Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: tools/perf/benchmarks/blink_perf_unittest.py

Issue 2941763004: Explicitly setting names for stories in unittests (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/contrib/cluster_telemetry/page_set.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2017 The Chromium Authors. All rights reserved. 1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import unittest 5 import unittest
6 6
7 from telemetry import story 7 from telemetry import story
8 from telemetry.page import page as page_module 8 from telemetry.page import page as page_module
9 from telemetry.testing import options_for_unittests 9 from telemetry.testing import options_for_unittests
10 from telemetry.testing import page_test_test_case 10 from telemetry.testing import page_test_test_case
(...skipping 16 matching lines...) Expand all
27 self._options = options_for_unittests.GetCopy() 27 self._options = options_for_unittests.GetCopy()
28 # pylint: disable=protected-access 28 # pylint: disable=protected-access
29 self._measurement = blink_perf._BlinkPerfMeasurement() 29 self._measurement = blink_perf._BlinkPerfMeasurement()
30 # pylint: enable=protected-access 30 # pylint: enable=protected-access
31 31
32 def _CreateStorySetForTestFile(self, test_file_name): 32 def _CreateStorySetForTestFile(self, test_file_name):
33 story_set = story.StorySet(base_dir=self._BLINK_PERF_TEST_DATA_DIR, 33 story_set = story.StorySet(base_dir=self._BLINK_PERF_TEST_DATA_DIR,
34 serving_dirs={self._BLINK_PERF_TEST_DATA_DIR, 34 serving_dirs={self._BLINK_PERF_TEST_DATA_DIR,
35 self._BLINK_PERF_RESOURCES_DIR}) 35 self._BLINK_PERF_RESOURCES_DIR})
36 page = page_module.Page('file://' + test_file_name, story_set, 36 page = page_module.Page('file://' + test_file_name, story_set,
37 base_dir=story_set.base_dir) 37 base_dir=story_set.base_dir, name=test_file_name)
38 story_set.AddStory(page) 38 story_set.AddStory(page)
39 return story_set 39 return story_set
40 40
41 def testBlinkPerfTracingMetricsForMeasureTime(self): 41 def testBlinkPerfTracingMetricsForMeasureTime(self):
42 results = self.RunMeasurement(measurement=self._measurement, 42 results = self.RunMeasurement(measurement=self._measurement,
43 ps=self._CreateStorySetForTestFile('append-child-measure-time.html'), 43 ps=self._CreateStorySetForTestFile('append-child-measure-time.html'),
44 options=self._options) 44 options=self._options)
45 self.assertFalse(results.failures) 45 self.assertFalse(results.failures)
46 self.assertEquals(len(results.FindAllTraceValues()), 1) 46 self.assertEquals(len(results.FindAllTraceValues()), 1)
47 47
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 334
335 renderer_main.BeginSlice('blink', 'bar', 440, 455) 335 renderer_main.BeginSlice('blink', 'bar', 440, 455)
336 renderer_main.BeginSlice('blink', 'foo', 480, 490) 336 renderer_main.BeginSlice('blink', 'foo', 480, 490)
337 renderer_main.EndSlice(510, 510) 337 renderer_main.EndSlice(510, 510)
338 renderer_main.EndSlice(510, 505) 338 renderer_main.EndSlice(510, 505)
339 339
340 self.assertEquals( 340 self.assertEquals(
341 blink_perf._ComputeTraceEventsThreadTimeForBlinkPerf( 341 blink_perf._ComputeTraceEventsThreadTimeForBlinkPerf(
342 model, renderer_main, ['foo', 'bar']), 342 model, renderer_main, ['foo', 'bar']),
343 {'foo': [300], 'bar': [320]}) 343 {'foo': [300], 'bar': [320]})
OLDNEW
« no previous file with comments | « no previous file | tools/perf/contrib/cluster_telemetry/page_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698