Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2941043002: [ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:tools_menu to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:tools_menu to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2941043002 Cr-Commit-Position: refs/heads/master@{#480023} Committed: https://chromium.googlesource.com/chromium/src/+/c8d2a63048345a021592fa0afe5211f12bfffe82

Patch Set 1 #

Patch Set 2 : manual review. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -69 lines) Patch
M ios/chrome/browser/ui/tools_menu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm View 4 chunks +7 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_constants.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_model.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h View 1 1 chunk +2 lines, -2 lines 2 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 1 8 chunks +14 lines, -36 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm View 6 chunks +7 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm View 3 chunks +5 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm View 1 4 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
marq (ping after 24h)
manual review.
3 years, 6 months ago (2017-06-15 13:15:22 UTC) #3
marq (ping after 24h)
3 years, 6 months ago (2017-06-15 13:17:07 UTC) #6
stkhapugin
lgtm https://codereview.chromium.org/2941043002/diff/20001/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h File ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h (right): https://codereview.chromium.org/2941043002/diff/20001/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h#newcode56 ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h:56: @property(nonatomic, readonly, weak) UIButton* toolsButton; nit: this probably ...
3 years, 6 months ago (2017-06-15 15:43:55 UTC) #10
marq (ping after 24h)
https://codereview.chromium.org/2941043002/diff/20001/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h File ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h (right): https://codereview.chromium.org/2941043002/diff/20001/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h#newcode56 ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h:56: @property(nonatomic, readonly, weak) UIButton* toolsButton; On 2017/06/15 15:43:55, stkhapugin ...
3 years, 6 months ago (2017-06-16 12:11:14 UTC) #11
marq (ping after 24h)
3 years, 6 months ago (2017-06-16 12:11:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941043002/20001
3 years, 6 months ago (2017-06-16 12:11:59 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 12:17:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c8d2a63048345a021592fa0afe52...

Powered by Google App Engine
This is Rietveld 408576698