Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h

Issue 2941043002: [ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:tools_menu to ARC. (Closed)
Patch Set: manual review. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
index 4ef3a53374103bab516df963afb101a69c39e3e6..53c4fc675b42a3926da28c36703ca00415947ad4 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
@@ -53,12 +53,12 @@ extern NSString* const kToolsMenuRequestMobileId;
@property(nonatomic, assign) BOOL isCurrentPageBookmarked;
@property(nonatomic, assign) BOOL isTabLoading;
// The tool button to be shown hovering above the popup.
-@property(nonatomic, readonly) UIButton* toolsButton;
+@property(nonatomic, readonly, weak) UIButton* toolsButton;
stkhapugin 2017/06/15 15:43:55 nit: this probably is strong
marq (ping after 24h) 2017/06/16 12:11:14 No, it's a property that exposes (and mutates as a
// Keeps track of the items in tools menu.
@property(nonatomic, copy) NSArray* menuItems;
-@property(nonatomic, assign) id<ToolsPopupTableDelegate> delegate;
+@property(nonatomic, weak) id<ToolsPopupTableDelegate> delegate;
// Initializes the Tools popup menu.
- (void)initializeMenuWithConfiguration:(ToolsMenuConfiguration*)configuration;
« no previous file with comments | « ios/chrome/browser/ui/tools_menu/tools_menu_model.mm ('k') | ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698