Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm

Issue 2941043002: [ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:tools_menu to ARC. (Closed)
Patch Set: manual review. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm
diff --git a/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm b/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm
index faedbaf0686b3323ead8355483c3d7b9446bb52d..b9595131e9cc705131b99fed227a3b8d32f1a300 100644
--- a/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm
+++ b/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm
@@ -5,11 +5,14 @@
#import "ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h"
#include "base/mac/foundation_util.h"
-#import "base/mac/scoped_nsobject.h"
#import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
#import "ios/chrome/browser/ui/reading_list/number_badge_view.h"
#import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
// ID for cell reuse
static NSString* const kReadingListCellID = @"ReadingListCellID";
@@ -17,7 +20,7 @@ const CGFloat kToolsMenuItemTrailingMargin = 25;
} // namespace
@interface ReadingListMenuViewCell () {
- base::scoped_nsobject<NumberBadgeView> _badge;
+ NumberBadgeView* _badge;
}
@end
@@ -42,7 +45,7 @@ const CGFloat kToolsMenuItemTrailingMargin = 25;
[super initializeViews];
- _badge.reset([[NumberBadgeView alloc] initWithFrame:CGRectZero]);
+ _badge = [[NumberBadgeView alloc] initWithFrame:CGRectZero];
[_badge setTranslatesAutoresizingMaskIntoConstraints:NO];
[self.contentView addSubview:_badge];
@@ -65,7 +68,7 @@ const CGFloat kToolsMenuItemTrailingMargin = 25;
addObject:[self.title.centerYAnchor
constraintEqualToAnchor:self.contentView.centerYAnchor]];
[constraintsToApply
- addObject:[_badge.get().centerYAnchor
+ addObject:[_badge.centerYAnchor
constraintEqualToAnchor:self.contentView.centerYAnchor]];
[NSLayoutConstraint activateConstraints:constraintsToApply];

Powered by Google App Engine
This is Rietveld 408576698