Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm

Issue 2941043002: [ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:tools_menu to ARC. (Closed)
Patch Set: manual review. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
index 0392cd8ee38f2db7733dc9e8fa7be0ba9f10f1af..dc01e5ba94a46f22ea621beab6de90fdd9e46b4e 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
@@ -5,10 +5,13 @@
#import "ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h"
#include "base/i18n/rtl.h"
-#include "base/mac/objc_property_releaser.h"
#import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
#include "ui/base/l10n/l10n_util.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
const CGFloat kToolsMenuItemHorizontalMargin = 16;
// Increase the margin for RTL so the labels don't overlap the tools icon.
@@ -16,10 +19,7 @@ const CGFloat kToolsMenuItemHorizontalMarginRTL = 25;
static NSString* const kMenuItemCellID = @"MenuItemCellID";
}
-@implementation ToolsMenuViewItem {
- base::mac::ObjCPropertyReleaser _propertyReleaser_ToolsMenuViewItem;
-}
-
+@implementation ToolsMenuViewItem
@synthesize accessibilityIdentifier = _accessibilityIdentifier;
@synthesize active = _active;
@synthesize title = _title;
@@ -29,7 +29,6 @@ static NSString* const kMenuItemCellID = @"MenuItemCellID";
- (id)init {
self = [super init];
if (self) {
- _propertyReleaser_ToolsMenuViewItem.Init(self, [ToolsMenuViewItem class]);
_active = YES;
}
@@ -47,7 +46,7 @@ static NSString* const kMenuItemCellID = @"MenuItemCellID";
+ (instancetype)menuItemWithTitle:(NSString*)title
accessibilityIdentifier:(NSString*)accessibilityIdentifier
command:(int)commandID {
- ToolsMenuViewItem* menuItem = [[[self alloc] init] autorelease];
+ ToolsMenuViewItem* menuItem = [[self alloc] init];
[menuItem setAccessibilityLabel:title];
[menuItem setAccessibilityIdentifier:accessibilityIdentifier];
[menuItem setTag:commandID];
@@ -58,10 +57,7 @@ static NSString* const kMenuItemCellID = @"MenuItemCellID";
@end
-@implementation ToolsMenuViewCell {
- base::mac::ObjCPropertyReleaser _propertyReleaser_ToolsMenuViewCell;
-}
-
+@implementation ToolsMenuViewCell
@synthesize title = _title;
@synthesize horizontalMargin = _horizontalMargin;
@@ -82,7 +78,6 @@ static NSString* const kMenuItemCellID = @"MenuItemCellID";
}
- (void)commonInitialization {
- _propertyReleaser_ToolsMenuViewCell.Init(self, [ToolsMenuViewCell class]);
_horizontalMargin = !base::i18n::IsRTL() ? kToolsMenuItemHorizontalMargin
: kToolsMenuItemHorizontalMarginRTL;
[self setBackgroundColor:[UIColor whiteColor]];

Powered by Google App Engine
This is Rietveld 408576698