Consolidated all CWVWebView test helpers inside web_view_test_util file.

Consolidated all CWVWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces caller to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces caller to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces caller to
   use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None

Review-Url: https://codereview.chromium.org/2940953003
Cr-Commit-Position: refs/heads/master@{#479972}
Committed: https://chromium.googlesource.com/chromium/src/+/e4ccee5a9fc9ac79623cc389f72ebbfdc04de10e

[Eugene But (OOO till 7-30), 2017-06-15 02:25:38]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 02:25:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-06-15 02:25:59]

eugenebut@chromium.org changed reviewers:
+ ichikawa@chromium.org, michaeldo@chromium.org

[Eugene But (OOO till 7-30), 2017-06-15 02:25:59]

PTAL

[commit-bot: I haz the power, 2017-06-15 02:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 02:33:56]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eugene But (OOO till 7-30), 2017-06-15 04:01:50]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 04:02:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hiroshi Ichikawa, 2017-06-15 04:07:19]

lgtm

[commit-bot: I haz the power, 2017-06-15 05:01:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 05:01:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaeldo, 2017-06-15 15:34:02]

On 2017/06/15 02:25:59, Eugene But wrote:
> PTAL

In description, please s/CRWWebView/CWVWebView.

[michaeldo, 2017-06-15 15:43:08]

LGTM! Thank you for test cleanup.

Also in description please replace 3 occurrences of "forces called to use" with
"forces caller to use"

https://codereview.chromium.org/2940953003/diff/1/ios/web_view/test/chrome_we...
File ios/web_view/test/chrome_web_view_test.mm (right):

https://codereview.chromium.org/2940953003/diff/1/ios/web_view/test/chrome_we...
ios/web_view/test/chrome_web_view_test.mm:13: #import "ios/testing/wait_util.h"
Remove wait_util.h import

[Eugene But (OOO till 7-30), 2017-06-16 00:59:07]

Description was changed from

==========
Consolidated all CRWWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces called to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces called to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces called
   to use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None
==========

to

==========
Consolidated all pleaseCWVWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces called to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces called to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces called
   to use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None
==========

[Eugene But (OOO till 7-30), 2017-06-16 00:59:41]

Description was changed from

==========
Consolidated all pleaseCWVWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces called to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces called to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces called
   to use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None
==========

to

==========
Consolidated all pleaseCWVWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces caller to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces caller to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces caller to
   use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None
==========

[Eugene But (OOO till 7-30), 2017-06-16 01:52:23]

https://codereview.chromium.org/2940953003/diff/1/ios/web_view/test/chrome_we...
File ios/web_view/test/chrome_web_view_test.mm (right):

https://codereview.chromium.org/2940953003/diff/1/ios/web_view/test/chrome_we...
ios/web_view/test/chrome_web_view_test.mm:13: #import "ios/testing/wait_util.h"
On 2017/06/15 15:43:08, michaeldo wrote:
> Remove wait_util.h import
Good catch. Done.

[Eugene But (OOO till 7-30), 2017-06-16 05:12:35]

Description was changed from

==========
Consolidated all pleaseCWVWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces caller to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces caller to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces caller to
   use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None
==========

to

==========
Consolidated all CWVWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces caller to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces caller to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces caller to
   use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None
==========

[Eugene But (OOO till 7-30), 2017-06-16 05:12:41]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-06-16 05:12:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeldo@chromium.org, ichikawa@chromium.org
Link to the patchset: https://codereview.chromium.org/2940953003/#ps20001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2017-06-16 05:13:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 06:53:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497589961195980,
"parent_rev": "ea4e23595168de37756554bdcf59d46434a06dc1", "commit_rev":
"e4ccee5a9fc9ac79623cc389f72ebbfdc04de10e"}

[commit-bot: I haz the power, 2017-06-16 06:54:11]

Description was changed from

==========
Consolidated all CWVWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces caller to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces caller to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces caller to
   use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None
==========

to

==========
Consolidated all CWVWebView test helpers inside web_view_test_util file.

Notable changes:
 - LoadUrl was moved from ChromeWebViewTest to web_view_test_util
   (this way API can be used in EG, integration and unit tests)
 - LoadUrl returns bool and forces caller to use result (this way API
   can be used in EG tests as well, which should not use ASSERT).
 - TapChromeWebViewElementWithId was renamed to TapWebViewElementWithId
   just for consistency
 - TapWebViewElementWithId function forces caller to use result (this
   way tests can assert in appropriate way)
 - WaitForWebViewLoadCompletionOrTimeout returns bool and forces caller to
   use result (this way API can be used in EG tests as well, which
   should not use ASSERT)
 - WaitForPageLoadCompletion renamed to
   WaitForWebViewLoadCompletionOrTimeout just for consistency

Currently web_view_test_util has 6 functions and will be split if it
grows to larger size.

BUG=None

Review-Url: https://codereview.chromium.org/2940953003
Cr-Commit-Position: refs/heads/master@{#479972}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4ccee5a9fc9ac79623cc389f72e...
==========

[commit-bot: I haz the power, 2017-06-16 06:54:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e4ccee5a9fc9ac79623cc389f72e...