Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2943063002: Removed Chrome prefix from ios_web_view_inttests test fixtures. (Closed)

Created:
3 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed Chrome prefix from ios_web_view_inttests test fixtures. Chrome prefix is used for ChromeWebView framework name, but not in any other class names, hence removed. BUG=None Review-Url: https://codereview.chromium.org/2943063002 Cr-Commit-Position: refs/heads/master@{#480289} Committed: https://chromium.googlesource.com/chromium/src/+/2712348504ba7d33815d89b6029df4c21cbba77c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -467 lines) Patch
M ios/web_view/test/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
D ios/web_view/test/chrome_web_view_kvo_inttest.mm View 1 chunk +0 lines, -182 lines 0 comments Download
D ios/web_view/test/chrome_web_view_restorable_state_inttest.mm View 1 chunk +0 lines, -64 lines 0 comments Download
D ios/web_view/test/chrome_web_view_test.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ios/web_view/test/chrome_web_view_test.mm View 1 chunk +0 lines, -135 lines 0 comments Download
A + ios/web_view/test/web_view_kvo_inttest.mm View 5 chunks +6 lines, -6 lines 0 comments Download
A + ios/web_view/test/web_view_restorable_state_inttest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/web_view/test/web_view_test.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ios/web_view/test/web_view_test.mm View 2 chunks +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Eugene But (OOO till 7-30)
PTAL
3 years, 6 months ago (2017-06-16 07:10:29 UTC) #2
Hiroshi Ichikawa
lgtm
3 years, 6 months ago (2017-06-16 07:47:28 UTC) #3
michaeldo
lgtm
3 years, 6 months ago (2017-06-16 18:38:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943063002/1
3 years, 6 months ago (2017-06-17 02:51:55 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-17 09:49:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2712348504ba7d33815d89b6029d...

Powered by Google App Engine
This is Rietveld 408576698