ios/web_view/test/chrome_web_view_restorable_state_inttest.mm - Issue 2940953003: Consolidated all CWVWebView test helpers inside web_view_test_util file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web_view/test/chrome_web_view_restorable_state_inttest.mm

Issue 2940953003: Consolidated all CWVWebView test helpers inside web_view_test_util file. (Closed)

Patch Set: Addressed review comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web_view/test/chrome_web_view_restorable_state_inttest.mm

diff --git a/ios/web_view/test/chrome_web_view_restorable_state_inttest.mm b/ios/web_view/test/chrome_web_view_restorable_state_inttest.mm

index 47af93fb0388f37c839bef4bdaeb0b21a64d15c0..0c682e06a9a7b7a80fa4a1981e6c1d94fa0c2728 100644

--- a/ios/web_view/test/chrome_web_view_restorable_state_inttest.mm

+++ b/ios/web_view/test/chrome_web_view_restorable_state_inttest.mm

@@ -41,10 +41,10 @@ TEST_F(ChromeWebViewRestorableStateTest, EncodeDecode) {

ASSERT_FALSE([web_view_ visibleURL]);

ASSERT_FALSE([web_view_ canGoBack]);

ASSERT_FALSE([web_view_ canGoForward]);

- LoadUrl(web_view_, [NSURL URLWithString:@"about:newtab"]);

+ ASSERT_TRUE(test::LoadUrl(web_view_, [NSURL URLWithString:@"about:newtab"]));

ASSERT_NSEQ(@"about:newtab", [web_view_ lastCommittedURL].absoluteString);

ASSERT_NSEQ(@"about:newtab", [web_view_ visibleURL].absoluteString);

- LoadUrl(web_view_, [NSURL URLWithString:@"about:blank"]);

+ ASSERT_TRUE(test::LoadUrl(web_view_, [NSURL URLWithString:@"about:blank"]));

ASSERT_NSEQ(@"about:blank", [web_view_ lastCommittedURL].absoluteString);

ASSERT_NSEQ(@"about:blank", [web_view_ visibleURL].absoluteString);

ASSERT_TRUE([web_view_ canGoBack]);