Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 2941763003: Cleanup ios_web_view integration tests. (Closed)

Created:
3 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup ios_web_view integration tests. Notable changes: - Moved web_view_ up to base class (it will be used in multiple tests) - Renamed web_view_interaction_test_util. to web_view_test_util. (this file is now much more than just interactions, but not big enough to do further split) - Moved CreateWebView() to web_view_test_util and reused in base fixture BUG=None Review-Url: https://codereview.chromium.org/2941763003 Cr-Commit-Position: refs/heads/master@{#479944} Committed: https://chromium.googlesource.com/chromium/src/+/be07fa38a26f1ee3b3ca0d36457e9d7ad87c9e47

Patch Set 1 #

Patch Set 2 : Moved CreateWebView to web_view_test_util.h #

Total comments: 2

Patch Set 3 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -151 lines) Patch
M ios/web_view/test/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web_view/test/chrome_web_view_kvo_inttest.mm View 1 2 chunks +4 lines, -17 lines 0 comments Download
M ios/web_view/test/chrome_web_view_restorable_state_inttest.mm View 1 2 chunks +21 lines, -30 lines 0 comments Download
M ios/web_view/test/chrome_web_view_test.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ios/web_view/test/chrome_web_view_test.mm View 1 2 2 chunks +3 lines, -1 line 0 comments Download
D ios/web_view/test/web_view_interaction_test_util.h View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D ios/web_view/test/web_view_interaction_test_util.mm View 1 1 chunk +0 lines, -66 lines 0 comments Download
A + ios/web_view/test/web_view_test_util.h View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
A + ios/web_view/test/web_view_test_util.mm View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Eugene But (OOO till 7-30)
3 years, 6 months ago (2017-06-14 22:50:24 UTC) #7
Hiroshi Ichikawa
lgtm
3 years, 6 months ago (2017-06-15 01:25:41 UTC) #8
michaeldo
On 2017/06/14 22:50:24, Eugene But wrote: Please remove extra "up" from CL title.
3 years, 6 months ago (2017-06-15 15:44:30 UTC) #9
michaeldo
lgtm. Thank you! https://codereview.chromium.org/2941763003/diff/20001/ios/web_view/test/chrome_web_view_test.mm File ios/web_view/test/chrome_web_view_test.mm (right): https://codereview.chromium.org/2941763003/diff/20001/ios/web_view/test/chrome_web_view_test.mm#newcode101 ios/web_view/test/chrome_web_view_test.mm:101: : web_view_(ios_web_view::test::CreateWebView()), No need for ios_web_view::
3 years, 6 months ago (2017-06-15 15:49:33 UTC) #10
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2941763003/diff/20001/ios/web_view/test/chrome_web_view_test.mm File ios/web_view/test/chrome_web_view_test.mm (right): https://codereview.chromium.org/2941763003/diff/20001/ios/web_view/test/chrome_web_view_test.mm#newcode101 ios/web_view/test/chrome_web_view_test.mm:101: : web_view_(ios_web_view::test::CreateWebView()), On 2017/06/15 15:49:33, michaeldo wrote: > No ...
3 years, 6 months ago (2017-06-16 01:55:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941763003/40001
3 years, 6 months ago (2017-06-16 01:56:39 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 04:13:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/be07fa38a26f1ee3b3ca0d36457e...

Powered by Google App Engine
This is Rietveld 408576698