Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 293893003: Web Animations: Rename TimedItem to AnimationSource (Closed)

Created:
6 years, 7 months ago by dstockwell
Modified:
6 years, 7 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Inactive, darktears, arv+blink, Steve Block, watchdog-blink-watchlist_google.com, Eric Willigers
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Update expectations. #

Patch Set 4 : Update expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+963 lines, -2014 lines) Patch
M LayoutTests/virtual/stable/webexposed/web-animations-api-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 2 chunks +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/web-animations-api.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/web-animations-api-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/Animation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/Animation.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/Animation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.h View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/AnimationPlayer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationPlayerTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
A + Source/core/animation/AnimationSource.h View 7 chunks +11 lines, -11 lines 0 comments Download
A + Source/core/animation/AnimationSource.cpp View 9 chunks +15 lines, -15 lines 0 comments Download
A + Source/core/animation/AnimationSource.idl View 1 chunk +1 line, -1 line 0 comments Download
A Source/core/animation/AnimationSourceTest.cpp View 1 chunk +775 lines, -0 lines 0 comments Download
A + Source/core/animation/AnimationSourceTiming.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/animation/AnimationSourceTiming.cpp View 6 chunks +24 lines, -24 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/AnimationTimeline.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/AnimationTimeline.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/AnimationTimeline.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationTimelineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InertAnimation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/InertAnimation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/Keyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/animation/TimedItem.h View 1 chunk +0 lines, -171 lines 0 comments Download
D Source/core/animation/TimedItem.cpp View 1 chunk +0 lines, -195 lines 0 comments Download
D Source/core/animation/TimedItem.idl View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/animation/TimedItemCalculations.h View 1 chunk +0 lines, -198 lines 0 comments Download
D Source/core/animation/TimedItemCalculationsTest.cpp View 1 chunk +0 lines, -214 lines 0 comments Download
D Source/core/animation/TimedItemTest.cpp View 1 chunk +0 lines, -775 lines 0 comments Download
D Source/core/animation/TimedItemTiming.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/core/animation/TimedItemTiming.cpp View 1 chunk +0 lines, -180 lines 0 comments Download
M Source/core/animation/Timing.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/TimingCalculations.h View 3 chunks +17 lines, -17 lines 0 comments Download
A + Source/core/animation/TimingCalculationsTest.cpp View 7 chunks +21 lines, -21 lines 0 comments Download
M Source/core/animation/TimingInputTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/core.gypi View 1 5 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dstockwell
6 years, 7 months ago (2014-05-20 01:51:12 UTC) #1
Timothy Loh
On 2014/05/20 01:51:12, dstockwell wrote: rslgtm
6 years, 7 months ago (2014-05-20 20:37:12 UTC) #2
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 7 months ago (2014-05-21 03:14:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/293893003/20001
6 years, 7 months ago (2014-05-21 03:14:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 09:15:14 UTC) #5
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 7 months ago (2014-05-21 21:53:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/293893003/30001
6 years, 7 months ago (2014-05-21 22:03:52 UTC) #7
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 7 months ago (2014-05-21 23:03:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/293893003/50001
6 years, 7 months ago (2014-05-21 23:04:14 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 05:05:33 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 08:24:44 UTC) #11
Message was sent while issue was closed.
Change committed as 174534

Powered by Google App Engine
This is Rietveld 408576698