components/translate/core/common/language_detection_logging_helper_unittest.cc - Issue 2938813003: [Sync] Nest UserEvent message classes within UserEventSpecifics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/common/language_detection_logging_helper_unittest.cc

Issue 2938813003: [Sync] Nest UserEvent message classes within UserEventSpecifics. (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/core/common/language_detection_logging_helper.cc ('k') | components/translate/core/common/translation_logging_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/common/language_detection_logging_helper_unittest.cc

diff --git a/components/translate/core/common/language_detection_logging_helper_unittest.cc b/components/translate/core/common/language_detection_logging_helper_unittest.cc

index fc9c7ebae0a333a7c9f1db77241ad47e3c228d27..948fa9d818914ac2d51fcf3ebc52130aa2f15f9d 100644

--- a/components/translate/core/common/language_detection_logging_helper_unittest.cc

+++ b/components/translate/core/common/language_detection_logging_helper_unittest.cc

@@ -19,7 +19,7 @@ TEST(LanguageDetectionLoggingHelperTest, ConstructUserEventSpecifics) {

details.is_cld_reliable = false;

details.adopted_language = "ja";

// Expected language detection.

- sync_pb::LanguageDetection lang_detection;

+ sync_pb::UserEventSpecifics::LanguageDetection lang_detection;

auto* const lang = lang_detection.add_detected_languages();

lang->set_language_code(details.cld_language);

lang->set_is_reliable(details.is_cld_reliable);

@@ -41,7 +41,7 @@ TEST(LanguageDetectionLoggingHelperTest, DontSetAdoptedLanguage) {

details.is_cld_reliable = true;