[Sync] Sanity test for UserEvents.

[Sync] Sanity test for UserEvents.

BUG=728753
Review-Url: https://codereview.chromium.org/2948303002
Cr-Commit-Position: refs/heads/master@{#483460}
Committed: https://chromium.googlesource.com/chromium/src/+/148e5e3c9eb4a821b39913b2673b6842adc4b7bc

[skym, 2017-06-22 20:43:07]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 20:43:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 21:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 21:44:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2017-06-23 17:28:54]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 17:29:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 18:53:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 18:53:58]

Dry run: This issue passed the CQ dry run.

[skym, 2017-06-23 18:59:29]

skym@chromium.org changed reviewers:
+ pnoland@chromium.org

[skym, 2017-06-23 18:59:30]

PTAL

[Patrick Noland, 2017-06-26 19:20:23]

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/migration_test.cc (right):

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/migration_test.cc:168: LOG(ERROR) << "SKYM
" << syncer::ModelTypeSetToString(migrate_types);
Did you mean to include this? If so, could you make the message a bit for
informative?

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc
(right):

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc:47:
// this isn't going to recover to fail the test case now.
[nit] Is this supposed to be "so fail the test case now?"

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc:48:
DCHECK(expected_specifics_.end() != iter);
Why DCHECK and not CHECK or assert?

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc:70:
SingleClientUserEventsSyncTest() : SyncTest(TWO_CLIENT) { DisableVerifier(); }
Why TWO_CLIENT?

[skym, 2017-06-26 19:59:29]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2017-06-26 19:59:40]

Updates for pnoland!

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/migration_test.cc (right):

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/migration_test.cc:168: LOG(ERROR) << "SKYM
" << syncer::ModelTypeSetToString(migrate_types);
On 2017/06/26 19:20:23, Patrick Noland wrote:
> Did you mean to include this? If so, could you make the message a bit for
> informative?

I did not! Whoops. Removed.

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc
(right):

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc:47:
// this isn't going to recover to fail the test case now.
On 2017/06/26 19:20:23, Patrick Noland wrote:
> [nit] Is this supposed to be "so fail the test case now?"

Done.

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc:48:
DCHECK(expected_specifics_.end() != iter);
On 2017/06/26 19:20:23, Patrick Noland wrote:
> Why DCHECK and not CHECK or assert?

Cannot ASSERT because GTEST and and this method has a non-void return type. Can
switch to CHECK though. Should behave the same as DCEHCK.

https://codereview.chromium.org/2948303002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc:70:
SingleClientUserEventsSyncTest() : SyncTest(TWO_CLIENT) { DisableVerifier(); }
On 2017/06/26 19:20:23, Patrick Noland wrote:
> Why TWO_CLIENT?

Whoops, thanks for catching this. I initially wrote it as two client and then
switched to single client, looks like I forgot to update this place.

[commit-bot: I haz the power, 2017-06-26 20:00:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patrick Noland, 2017-06-26 20:00:49]

lgtm

[commit-bot: I haz the power, 2017-06-26 20:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 20:03:28]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[skym, 2017-06-26 21:31:57]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 21:32:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 22:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 22:55:19]

Dry run: This issue passed the CQ dry run.

[skym, 2017-06-27 15:34:00]

skym@chromium.org changed reviewers:
+ holte@chromium.org

[skym, 2017-06-27 15:34:01]

+holte for testing/variations/OWNERS

[Steven Holte, 2017-06-27 20:35:49]

lgtm

[skym, 2017-06-29 18:40:07]

The CQ bit was checked by skym@chromium.org

[skym, 2017-06-29 18:40:08]

The patchset sent to the CQ was uploaded after l-g-t-m from pnoland@chromium.org
Link to the patchset: https://codereview.chromium.org/2948303002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-29 18:40:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 20:13:30]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498761607302430,
"parent_rev": "9cb51a30376e75d2de0d20db35dc346d0fcf92f4", "commit_rev":
"148e5e3c9eb4a821b39913b2673b6842adc4b7bc"}

[commit-bot: I haz the power, 2017-06-29 20:13:41]

Description was changed from

==========
[Sync] Sanity test for UserEvents.

BUG=728753
==========

to

==========
[Sync] Sanity test for UserEvents.

BUG=728753

Review-Url: https://codereview.chromium.org/2948303002
Cr-Commit-Position: refs/heads/master@{#483460}
Committed:
https://chromium.googlesource.com/chromium/src/+/148e5e3c9eb4a821b39913b2673b...
==========

[commit-bot: I haz the power, 2017-06-29 20:13:44]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/148e5e3c9eb4a821b39913b2673b...