[Extensions] Remove unsafe variants of CallModuleMethod

[Extensions] Remove unsafe variants of CallModuleMethod

ModuleSystem::CallModuleMethod() didn't allow for asynchronous
execution. This method is no longer used, so remove it entirely.
Also move ScriptContext::CallFunction to be private, since it is
now only used from within that class.

BUG=629431
Review-Url: https://codereview.chromium.org/2936083002
Cr-Commit-Position: refs/heads/master@{#479364}
Committed: https://chromium.googlesource.com/chromium/src/+/cf5482bdd348723049d1024d1e95692c51739cc2

[Devlin, 2017-06-13 22:55:38]

Description was changed from

==========
[Extensions] Remove unsafe variants of CallModuleMethod

ModuleSystem::CallModuleMethod() didn't allow for asynchronous
execution. This method is no longer used, so remove it and rename the
Safe() variants to CallModuleMethod(). Also move
ScriptContext::CallFunction to be private, since it is now only used
from within that class.

BUG=629431
==========

to

==========
[Extensions] Remove unsafe variants of CallModuleMethod

ModuleSystem::CallModuleMethod() didn't allow for asynchronous
execution. This method is no longer used, so remove it entirely.
Also move ScriptContext::CallFunction to be private, since it is
now only used from within that class.

BUG=629431
==========

[Devlin, 2017-06-13 22:56:06]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 22:56:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 00:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 00:09:31]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-14 00:11:11]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2017-06-14 00:11:12]

Another one for you, lazyboy@.

[lazyboy, 2017-06-14 01:19:23]

lgtm

[Devlin, 2017-06-14 13:13:26]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-06-14 13:13:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 13:18:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497446006471020,
"parent_rev": "e62543149bb4f58e37cce4d789ff0ebdc1d516f8", "commit_rev":
"cf5482bdd348723049d1024d1e95692c51739cc2"}

[commit-bot: I haz the power, 2017-06-14 13:18:29]

Description was changed from

==========
[Extensions] Remove unsafe variants of CallModuleMethod

ModuleSystem::CallModuleMethod() didn't allow for asynchronous
execution. This method is no longer used, so remove it entirely.
Also move ScriptContext::CallFunction to be private, since it is
now only used from within that class.

BUG=629431
==========

to

==========
[Extensions] Remove unsafe variants of CallModuleMethod

ModuleSystem::CallModuleMethod() didn't allow for asynchronous
execution. This method is no longer used, so remove it entirely.
Also move ScriptContext::CallFunction to be private, since it is
now only used from within that class.

BUG=629431

Review-Url: https://codereview.chromium.org/2936083002
Cr-Commit-Position: refs/heads/master@{#479364}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf5482bdd348723049d1024d1e95...
==========

[commit-bot: I haz the power, 2017-06-14 13:18:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf5482bdd348723049d1024d1e95...