Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: extensions/renderer/script_context.h

Issue 2936083002: [Extensions] Remove unsafe variants of CallModuleMethod (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context.h
diff --git a/extensions/renderer/script_context.h b/extensions/renderer/script_context.h
index c314d825d74d32cc493f5f7643b2980451c0957b..c1408949fc68efb0bd03e24d4cba01ed38361427 100644
--- a/extensions/renderer/script_context.h
+++ b/extensions/renderer/script_context.h
@@ -109,16 +109,10 @@ class ScriptContext : public RequestSender::Source {
// the context is in the process of being destroyed.
content::RenderFrame* GetRenderFrame() const;
- // DEPRECATED.
- v8::Local<v8::Value> CallFunction(const v8::Local<v8::Function>& function,
- int argc,
- v8::Local<v8::Value> argv[]) const;
-
// Safely calls the v8::Function, respecting the page load deferrer and
// possibly executing asynchronously.
// Doesn't catch exceptions; callers must do that if they want.
// USE THESE METHODS RATHER THAN v8::Function::Call WHEREVER POSSIBLE.
- // TODO(devlin): Remove the above variants in favor of this.
void SafeCallFunction(const v8::Local<v8::Function>& function,
int argc,
v8::Local<v8::Value> argv[]);
@@ -226,6 +220,11 @@ class ScriptContext : public RequestSender::Source {
const RunScriptExceptionHandler& exception_handler);
private:
+ // DEPRECATED.
+ v8::Local<v8::Value> CallFunction(const v8::Local<v8::Function>& function,
+ int argc,
+ v8::Local<v8::Value> argv[]) const;
+
class Runner;
// Whether this context is valid.
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698