Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: extensions/renderer/module_system.h

Issue 2936083002: [Extensions] Remove unsafe variants of CallModuleMethod (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/module_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system.h
diff --git a/extensions/renderer/module_system.h b/extensions/renderer/module_system.h
index d485659458077366afaf49ce2cacbb0f023640ba..977be618c691c276de069b64753c1324d21f33e3 100644
--- a/extensions/renderer/module_system.h
+++ b/extensions/renderer/module_system.h
@@ -84,15 +84,10 @@ class ModuleSystem : public ObjectBackedNativeHandler,
v8::Local<v8::String> name);
// Calls the specified method exported by the specified module. This is
- // equivalent to calling require('module_name').method_name() from JS.
- // DEPRECATED: see crbug.com/629431
- // TODO(devlin): Remove these.
- v8::Local<v8::Value> CallModuleMethod(const std::string& module_name,
- const std::string& method_name,
- int argc,
- v8::Local<v8::Value> argv[]);
-
- // Same as the above, but allows for blocking execution.
+ // equivalent to calling require('module_name').method_name() from JS. Note:
+ // this may result in asynchronous execution if javascript is presently
+ // disabled.
+ // TODO(devlin): Rename this to just CallModuleMethod()?
void CallModuleMethodSafe(const std::string& module_name,
const std::string& method_name);
void CallModuleMethodSafe(const std::string& module_name,
« no previous file with comments | « no previous file | extensions/renderer/module_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698