[Extensions] Remove unsafe variants of CallModuleMethod

extensions/renderer/script_context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
 #define EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
 
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 91 matching lines @@
   const SafeBuiltins* safe_builtins() const { return &safe_builtins_; }
 
   // Returns the ID of the extension associated with this context, or empty
   // string if there is no such extension.
   const std::string& GetExtensionID() const;
 
   // Returns the RenderFrame associated with this context. Can return NULL if
   // the context is in the process of being destroyed.
   content::RenderFrame* GetRenderFrame() const;
 
-  // DEPRECATED.
-  v8::Local<v8::Value> CallFunction(const v8::Local<v8::Function>& function,
-                                    int argc,
-                                    v8::Local<v8::Value> argv[]) const;
-
   // Safely calls the v8::Function, respecting the page load deferrer and
   // possibly executing asynchronously.
   // Doesn't catch exceptions; callers must do that if they want.
   // USE THESE METHODS RATHER THAN v8::Function::Call WHEREVER POSSIBLE.
-  // TODO(devlin): Remove the above variants in favor of this.
   void SafeCallFunction(const v8::Local<v8::Function>& function,
                         int argc,
                         v8::Local<v8::Value> argv[]);
   void SafeCallFunction(
       const v8::Local<v8::Function>& function,
       int argc,
       v8::Local<v8::Value> argv[],
       const ScriptInjectionCallback::CompleteCallback& callback);
 
   // Returns the availability of the API |api_name|.
@@ skipping 87 matching lines @@
 
   // Runs |code|, labelling the script that gets created as |name| (the name is
   // used in the devtools and stack traces). |exception_handler| will be called
   // re-entrantly if an exception is thrown during the script's execution.
   v8::Local<v8::Value> RunScript(
       v8::Local<v8::String> name,
       v8::Local<v8::String> code,
       const RunScriptExceptionHandler& exception_handler);
 
  private:
+  // DEPRECATED.
+  v8::Local<v8::Value> CallFunction(const v8::Local<v8::Function>& function,
+                                    int argc,
+                                    v8::Local<v8::Value> argv[]) const;
+
   class Runner;
 
   // Whether this context is valid.
   bool is_valid_;
 
   // The v8 context the bindings are accessible to.
   v8::Global<v8::Context> v8_context_;
 
   // The WebLocalFrame associated with this context. This can be NULL because
   // this object can outlive is destroyed asynchronously.
@@ skipping 34 matching lines @@
   std::unique_ptr<Runner> runner_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(ScriptContext);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_