Explicitly setting names for stories in used page_sets

Explicitly setting names for stories in used page_sets

BUG=chromium:720002
Review-Url: https://codereview.chromium.org/2935783004
Cr-Commit-Position: refs/heads/master@{#479081}
Committed: https://chromium.googlesource.com/chromium/src/+/335063f9c6eda65548bda5e27eda2a9d5bce388c

[ashleymarie1, 2017-06-12 21:29:24]

ashleymarie@chromium.org changed reviewers:
+ nednguyen@google.com

[ashleymarie1, 2017-06-12 21:29:25]

Setting the last of the names for stories

[ashleymarie1, 2017-06-12 21:30:02]

The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 21:30:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-06-12 21:31:22]

lgtm

[ashleymarie1, 2017-06-12 21:35:05]

The CQ bit was unchecked by ashleymarie@chromium.org

[ashleymarie1, 2017-06-12 21:35:14]

The CQ bit was checked by ashleymarie@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:35:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 00:40:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 00:40:59]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ashleymarie1, 2017-06-13 17:26:12]

The CQ bit was checked by ashleymarie@chromium.org

[ashleymarie1, 2017-06-13 17:26:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2935783004/#ps20001
(title: "Explicitly setting names for stories in used page_sets")

[commit-bot: I haz the power, 2017-06-13 17:26:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 18:50:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497374772715970,
"parent_rev": "76ea4f567679fb6bdbe02d34bd6d57a66e02657b", "commit_rev":
"335063f9c6eda65548bda5e27eda2a9d5bce388c"}

[commit-bot: I haz the power, 2017-06-13 18:50:48]

Description was changed from

==========
Explicitly setting names for stories in used page_sets

BUG=chromium:720002
==========

to

==========
Explicitly setting names for stories in used page_sets

BUG=chromium:720002

Review-Url: https://codereview.chromium.org/2935783004
Cr-Commit-Position: refs/heads/master@{#479081}
Committed:
https://chromium.googlesource.com/chromium/src/+/335063f9c6eda65548bda5e27eda...
==========

[commit-bot: I haz the power, 2017-06-13 18:50:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/335063f9c6eda65548bda5e27eda...

[nednguyen, 2017-06-13 18:55:25]

https://codereview.chromium.org/2935783004/diff/20001/tools/perf/page_sets/st...
File tools/perf/page_sets/story_set_unittest.py (right):

https://codereview.chromium.org/2935783004/diff/20001/tools/perf/page_sets/st...
tools/perf/page_sets/story_set_unittest.py:47: self.assertTrue(story.name != '',
forgot to comment on this, instead of assertTrue(story.name != ''), it's better
to do:

assertTrue(story.name)

or you can also do assertTrue(story_set.verify_names)


But given that we gonna flip the switch & delete this soon, probably it isn't
worth fixing this.