Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: tools/perf/page_sets/story_set_unittest.py

Issue 2935783004: Explicitly setting names for stories in used page_sets (Closed)
Patch Set: Explicitly setting names for stories in used page_sets Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/page_reload_cases.py ('k') | tools/perf/page_sets/top_10_mobile.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 6
7 import page_sets 7 import page_sets
8 8
9 from telemetry import decorators 9 from telemetry import decorators
10 from telemetry import page 10 from telemetry import page
(...skipping 20 matching lines...) Expand all
31 if story_set_class is page_sets.ToughSchedulingCasesPageSet: 31 if story_set_class is page_sets.ToughSchedulingCasesPageSet:
32 continue 32 continue
33 story_set = story_set_class() 33 story_set = story_set_class()
34 for story in story_set: 34 for story in story_set:
35 if isinstance(story, page.Page): 35 if isinstance(story, page.Page):
36 self.assertFalse( 36 self.assertFalse(
37 story.synthetic_delays, 37 story.synthetic_delays,
38 'Page %s in page set %s has non empty synthetic delay. ' 38 'Page %s in page set %s has non empty synthetic delay. '
39 'Synthetic delay is no longer supported. See crbug.com/508538.' % 39 'Synthetic delay is no longer supported. See crbug.com/508538.' %
40 (story.display_name, story_set.Name())) 40 (story.display_name, story_set.Name()))
41
42 def testNoStorySetDefinedWithUnnamedStories(self):
43 for story_set_class in self.GetAllStorySetClasses(self.story_sets_dir,
44 self.top_level_dir):
45 story_set = story_set_class()
46 for story in story_set:
47 self.assertTrue(story.name != '',
nednguyen 2017/06/13 18:55:25 forgot to comment on this, instead of assertTrue(s
48 'stories must be named: ' + str(story_set_class))
OLDNEW
« no previous file with comments | « tools/perf/page_sets/page_reload_cases.py ('k') | tools/perf/page_sets/top_10_mobile.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698