Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: tools/perf/page_sets/top_10_mobile.py

Issue 2935783004: Explicitly setting names for stories in used page_sets (Closed)
Patch Set: Explicitly setting names for stories in used page_sets Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/top_10_mobile.py
diff --git a/tools/perf/page_sets/top_10_mobile.py b/tools/perf/page_sets/top_10_mobile.py
index b788fbd7fc713a66c2d94200826b090ecc4360b2..fca2dfea54123828e8ae6e1289499c140e042519 100644
--- a/tools/perf/page_sets/top_10_mobile.py
+++ b/tools/perf/page_sets/top_10_mobile.py
@@ -47,7 +47,7 @@ class Top10MobilePage(page_module.Page):
super(Top10MobilePage, self).__init__(
url=url, page_set=page_set, credentials_path = 'data/credentials.json',
shared_page_state_class=shared_page_state.SharedMobilePageState,
- cache_temperature=cache_temperature)
+ cache_temperature=cache_temperature, name=url)
self.archive_data_file = 'data/top_10_mobile.json'
self._run_no_page_interactions = run_no_page_interactions
self._collect_memory_dumps = collect_memory_dumps
@@ -67,7 +67,8 @@ class _Top10MobilePageSet(story.StorySet):
""" Base class for Top 10 mobile sites """
def __init__(self, run_no_page_interactions=False,
- collect_memory_dumps=False, cache_temperatures=None):
+ collect_memory_dumps=False, cache_temperatures=None,
+ verify_names=True):
super(_Top10MobilePageSet, self).__init__(
archive_data_file='data/top_10_mobile.json',
cloud_storage_bucket=story.PARTNER_BUCKET)

Powered by Google App Engine
This is Rietveld 408576698