Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: tools/perf/page_sets/story_set_unittest.py

Issue 2935783004: Explicitly setting names for stories in used page_sets (Closed)
Patch Set: Explicitly setting names for stories in used page_sets Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/page_reload_cases.py ('k') | tools/perf/page_sets/top_10_mobile.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/story_set_unittest.py
diff --git a/tools/perf/page_sets/story_set_unittest.py b/tools/perf/page_sets/story_set_unittest.py
index 35247c6e76f911f061a6b4bcaab378ea2d1ecbf0..b3ff3d049d5664646d0f69e2dcfef264dae8af1b 100644
--- a/tools/perf/page_sets/story_set_unittest.py
+++ b/tools/perf/page_sets/story_set_unittest.py
@@ -38,3 +38,11 @@ class StorySetUnitTest(story_set_smoke_test.StorySetSmokeTest):
'Page %s in page set %s has non empty synthetic delay. '
'Synthetic delay is no longer supported. See crbug.com/508538.' %
(story.display_name, story_set.Name()))
+
+ def testNoStorySetDefinedWithUnnamedStories(self):
+ for story_set_class in self.GetAllStorySetClasses(self.story_sets_dir,
+ self.top_level_dir):
+ story_set = story_set_class()
+ for story in story_set:
+ self.assertTrue(story.name != '',
nednguyen 2017/06/13 18:55:25 forgot to comment on this, instead of assertTrue(s
+ 'stories must be named: ' + str(story_set_class))
« no previous file with comments | « tools/perf/page_sets/page_reload_cases.py ('k') | tools/perf/page_sets/top_10_mobile.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698