Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2937383002: [CSS Typed OM] Add missing error handling in the CSSTranslation constructor (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Add missing error handling in the CSSTranslation constructor BUG=545318 Review-Url: https://codereview.chromium.org/2937383002 Cr-Commit-Position: refs/heads/master@{#481446} Committed: https://chromium.googlesource.com/chromium/src/+/5753b2be46cb941bba07f38cd4bdde222a4c7f96

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -49 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html View 3 chunks +55 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.cpp View 1 chunk +13 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (16 generated)
meade_UTC10
hi nainar, PTAL
3 years, 6 months ago (2017-06-16 06:22:21 UTC) #2
nainar
lgtm
3 years, 6 months ago (2017-06-16 06:31:48 UTC) #5
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-19 04:10:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937383002/60001
3 years, 6 months ago (2017-06-21 06:49:22 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/484220)
3 years, 6 months ago (2017-06-21 08:12:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937383002/60001
3 years, 6 months ago (2017-06-22 03:00:46 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 05:10:10 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5753b2be46cb941bba07f38cd4bd...

Powered by Google App Engine
This is Rietveld 408576698