Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2935013002: Reland of Change default minimum screencast frame rate to zero. (patchset #1 id:1 of https://codere… (Closed)

Created:
3 years, 6 months ago by Guido Urdaneta
Modified:
3 years, 6 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Reland of Change default minimum screencast frame rate to zero. (patchset #1 id:1 of https://codereview.chromium.org/2919973003/ ) Reason for revert: The original patch does fix the bug. Original issue's description: > Revert of Change default minimum screencast frame rate to zero. (patchset #1 id:1 of https://codereview.chromium.org/2918113002/ ) > > Reason for revert: > Does not properly fix the bug. > > Original issue's description: > > Change default minimum screencast frame rate to zero. > > > > This is causing issues with refresh-interval computations that > > treat zero as a special value and expect zero as the default > > minimum, as it was with the old constraints algorithm. > > > > BUG=725696 > > > > Review-Url: https://codereview.chromium.org/2918113002 > > Cr-Commit-Position: refs/heads/master@{#476728} > > Committed: https://chromium.googlesource.com/chromium/src/+/9d5685faf6178778aaec42384e4c3f81890799b5 > > TBR=hbos@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=725696 > > Review-Url: https://codereview.chromium.org/2919973003 > Cr-Commit-Position: refs/heads/master@{#476836} > Committed: https://chromium.googlesource.com/chromium/src/+/56ed98a48e61f1ba075a5352939155379f21b2c2 TBR=hbos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725696 Review-Url: https://codereview.chromium.org/2921123002 Cr-Original-Original-Commit-Position: refs/heads/master@{#476899} Review-Url: https://codereview.chromium.org/2929573002 . Cr-Original-Commit-Position: refs/branch-heads/3112@{#218} Cr-Original-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Review-Url: https://codereview.chromium.org/2935013002 . Cr-Commit-Position: refs/branch-heads/3071@{#781} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4b4922a6746be9095e7f22da4357a017f9b640bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M content/renderer/media/media_stream_constraints_util_video_content.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Guido Urdaneta
3 years, 6 months ago (2017-06-13 09:47:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b4922a6746be9095e7f22da4357a017f9b640bb.

Powered by Google App Engine
This is Rietveld 408576698