Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2921123002: Reland of Change default minimum screencast frame rate to zero. (Closed)

Created:
3 years, 6 months ago by Guido Urdaneta
Modified:
3 years, 6 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org, miu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Change default minimum screencast frame rate to zero. (patchset #1 id:1 of https://codereview.chromium.org/2919973003/ ) Reason for revert: Will fix the patch before relanding. Original issue's description: > Revert of Change default minimum screencast frame rate to zero. (patchset #1 id:1 of https://codereview.chromium.org/2918113002/ ) > > Reason for revert: > Does not properly fix the bug. > > Original issue's description: > > Change default minimum screencast frame rate to zero. > > > > This is causing issues with refresh-interval computations that > > treat zero as a special value and expect zero as the default > > minimum, as it was with the old constraints algorithm. > > > > BUG=725696 > > > > Review-Url: https://codereview.chromium.org/2918113002 > > Cr-Commit-Position: refs/heads/master@{#476728} > > Committed: https://chromium.googlesource.com/chromium/src/+/9d5685faf6178778aaec42384e4c3f81890799b5 > > TBR=hbos@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=725696 > > Review-Url: https://codereview.chromium.org/2919973003 > Cr-Commit-Position: refs/heads/master@{#476836} > Committed: https://chromium.googlesource.com/chromium/src/+/56ed98a48e61f1ba075a5352939155379f21b2c2 TBR=hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725696 Review-Url: https://codereview.chromium.org/2921123002 Cr-Commit-Position: refs/heads/master@{#476899} Committed: https://chromium.googlesource.com/chromium/src/+/14b29e4c08342d12e9eb607158f6d18cabf650c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M content/renderer/media/media_stream_constraints_util_video_content.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Guido Urdaneta
Created Reland of Change default minimum screencast frame rate to zero.
3 years, 6 months ago (2017-06-03 00:24:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921123002/1
3 years, 6 months ago (2017-06-03 17:23:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/14b29e4c08342d12e9eb607158f6d18cabf650c5
3 years, 6 months ago (2017-06-03 17:24:00 UTC) #7
Guido Urdaneta
3 years, 6 months ago (2017-06-08 23:20:31 UTC) #8
Message was sent while issue was closed.
Relanded without modification since the original patch was actually correct.

Powered by Google App Engine
This is Rietveld 408576698