Chromium Code Reviews
DescriptionReland of Change default minimum screencast frame rate to zero. (patchset #1 id:1 of https://codereview.chromium.org/2919973003/ )
Reason for revert:
Will fix the patch before relanding.
Original issue's description:
> Revert of Change default minimum screencast frame rate to zero. (patchset #1 id:1 of https://codereview.chromium.org/2918113002/ )
>
> Reason for revert:
> Does not properly fix the bug.
>
> Original issue's description:
> > Change default minimum screencast frame rate to zero.
> >
> > This is causing issues with refresh-interval computations that
> > treat zero as a special value and expect zero as the default
> > minimum, as it was with the old constraints algorithm.
> >
> > BUG=725696
> >
> > Review-Url: https://codereview.chromium.org/2918113002
> > Cr-Commit-Position: refs/heads/master@{#476728}
> > Committed: https://chromium.googlesource.com/chromium/src/+/9d5685faf6178778aaec42384e4c3f81890799b5
>
> TBR=hbos@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=725696
>
> Review-Url: https://codereview.chromium.org/2919973003
> Cr-Commit-Position: refs/heads/master@{#476836}
> Committed: https://chromium.googlesource.com/chromium/src/+/56ed98a48e61f1ba075a5352939155379f21b2c2
TBR=hbos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=725696
Review-Url: https://codereview.chromium.org/2921123002
Cr-Original-Commit-Position: refs/heads/master@{#476899}
Review-Url: https://codereview.chromium.org/2929573002 .
Cr-Commit-Position: refs/branch-heads/3112@{#218}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/b20dec95b9faf5c28d4cf7c38311d71bf1ce111a
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||